Skip Menu |

This queue is for tickets about the WWW-Myspace CPAN distribution.

Report information
The Basics
Id: 18168
Status: resolved
Priority: 0/
Queue: WWW-Myspace

People
Owner: GRANTG [...] cpan.org
Requestors: olaf [...] vilerichard.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: captcha -- anonymous request blocking
Hi Grant, I've noticed today that some friend requests are blocked by people who only wish to add people that they know. This patch sends a slightly different error code + message for those cases. The benefit is that with the new message you can opt to continue adding friends without going to myspace to deal with someone you don't know anyway. Here's the patch, made against the latest release, so I hope it doesn't cause conflicts with that other patch. Note to self: stop sending patches. :) 25a26 Show quoted text
> use Contextual::Return;
2122c2123 < FP => 'Failed, you already have a pending friend request for this person', --- Show quoted text
> FP => 'Failed, you already have a pending
friend request for this person.', 2123a2125 Show quoted text
> FB => 'Failed, CAPTCHA response requested.
Anonymous requests blocked.', 2164a2167,2171 Show quoted text
> # Check for anonymous blocking CAPTCHA > elsif ( $page =~ /only accepts add requests from
people he\/she knows/ ) { Show quoted text
> $return_code = 'FB'; > } >
2171c2178,2181 < return $return_code, $status_codes{$return_code}; --- Show quoted text
> return ( > LIST { $return_code, $status_codes{$return_code} } > STR { $return_code } > );
From: olaf [...] vilerichard.com
Let me add that you can use this friend id as a test case: 6759473
From: olaf [...] vilerichard.com
Sigh. Correction: That previous id was from a different test. 10658889 is the proper test id. http://collect.myspace.com/index.cfm?fuseaction=invite.addfriend_verify&friendID=10658889 On Tue Mar 14 13:17:10 2006, guest wrote: Show quoted text
> Let me add that you can use this friend id as a test case: 6759473
Subject: Re: [rt.cpan.org #18168] captcha -- anonymous request blocking
Date: Tue, 14 Mar 2006 10:45:40 -0800
To: bug-WWW-Myspace [...] rt.cpan.org
From: Grant Grueninger <grantg [...] spamarrest.com>
Hi Olaf, Patches are good. I had to change "FB" to "FA", because "FB" is now for users who block bands. On a related note I re-wrote the routine over the past couple of days because I discovered that you had to get the page, then check stuff, then submit it. I'm not actually sure how you're getting these response codes to work on the current version of the module. In fact, I'm going to email you a dist of the current version so we're almost on the same page, so check your junk mail filter. :) Grant On Mar 14, 2006, at 10:14 AM, Guest via RT wrote: Show quoted text
> > Tue Mar 14 13:14:34 2006: Request 18168 was acted upon. > Transaction: Ticket created by guest > Queue: WWW-Myspace > Subject: captcha -- anonymous request blocking > Owner: Nobody > Requestors: olaf@vilerichard.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18168 > > > > Hi Grant, > > I've noticed today that some friend requests are blocked by people who > only wish to add people that they know. This patch sends a slightly > different error code + message for those cases. The benefit is that > with the new message you can opt to continue adding friends without > going to myspace to deal with someone you don't know anyway. > Here's the > patch, made against the latest release, so I hope it doesn't cause > conflicts with that other patch. Note to self: stop sending > patches. :) > > 25a26
>> use Contextual::Return;
> 2122c2123 > < FP => 'Failed, you already have a pending > friend request for this person', > ---
>> FP => 'Failed, you already have a pending
> friend request for this person.', > 2123a2125
>> FB => 'Failed, CAPTCHA response requested.
> Anonymous requests blocked.', > 2164a2167,2171
>> # Check for anonymous blocking CAPTCHA >> elsif ( $page =~ /only accepts add requests from
> people he\/she knows/ ) {
>> $return_code = 'FB'; >> } >>
> 2171c2178,2181 > < return $return_code, $status_codes{$return_code}; > ---
>> return ( >> LIST { $return_code, $status_codes{$return_code} } >> STR { $return_code } >> );
>
-- Grant Grueninger Commercial Systems Corporation http://www.cscorp.com/ 818-760-1649
Subject: Re: [rt.cpan.org #18168] captcha -- anonymous request blocking
Date: Tue, 14 Mar 2006 14:03:44 -0500
To: bug-WWW-Myspace [...] rt.cpan.org
From: Olaf Alders <olaf [...] vilerichard.com>
Hi Grant, On 14-Mar-06, at 1:46 PM, grantg@spamarrest.com via RT wrote: Show quoted text
> > Patches are good. I had to change "FB" to "FA", because "FB" is now > for users who block bands.
That sounds good! Show quoted text
> > On a related note I re-wrote the routine over the past couple of days > because I discovered that you had to get the page, then check stuff, > then submit it. I'm not actually sure how you're getting these > response codes to work on the current version of the module.
What I'm do with the FC is that I just pull up the page in my browser, fill out the info, submit the page and continue the script. The script doesn't try to resend the request, but that's okay since I've just done it manually. Not sure if that's what you're asking? Show quoted text
> > In fact, I'm going to email you a dist of the current version so > we're almost on the same page, so check your junk mail filter. :)
Great. I'll watch for it! Olaf -- Olaf Alders olaf@vilerichard.com http://www.vilerichard.com -- pop tunes http://cdbaby.com/cd/vilerichard
Subject: Re: [rt.cpan.org #18168] captcha -- anonymous request blocking
Date: Tue, 14 Mar 2006 11:11:37 -0800
To: bug-WWW-Myspace [...] rt.cpan.org
From: Grant Grueninger <grantg [...] spamarrest.com>
No, the CAPTCHA handling I understood. The response codes in version 0.32 are checked after the add-friend form is submitted, so I was just getting a lot of "FN" codes coming back from send_friend_request instead of the right code. The new version first loads the friend verify page, does the RegExp checking, then posts if appropriate. Well, you'll see in a second anyway - dist is on it's way. Grant On Mar 14, 2006, at 11:04 AM, Olaf Alders via RT wrote: Show quoted text
> [...]
>> >> On a related note I re-wrote the routine over the past couple of days >> because I discovered that you had to get the page, then check stuff, >> then submit it. I'm not actually sure how you're getting these >> response codes to work on the current version of the module.
> > What I'm do with the FC is that I just pull up the page in my > browser, fill out the info, submit the page and continue the script. > The script doesn't try to resend the request, but that's okay since > I've just done it manually. Not sure if that's what you're asking?
[...] -- Grant Grueninger Commercial Systems Corporation http://www.cscorp.com/ 818-760-1649