Bug #18162 for Module-Build: .packlist written to the wrong location under Module::Install

On Mar 14, 2006, at 11:32 PM, Ken_Williams via RT wrote: Show quoted text
Show quoted text
If i read the M::B documentation correctly, there is no support for a 'name' parameter, just 'module_name' and 'dist_name', correct? Show quoted text
You could accept 'name' to be shorthand for 'module_name' i suppose, or use the logic that 'Build dist' would use to make the Feed-Find.VERSION.tgz.. but of course, that's heuristics. Show quoted text
That sounds quite acceptable -- i've coded a workaround in cpanplus for now at least. Perhaps you can move this bug to the M::I queue and hopefully they can pick up on it. Thanks for the prompt reply, -- Jos Boumans "Whenever you find you are on the side of the majority, it is time to pause and reflect." - Mark Twain CPANPLUS http://cpanplus.sf.net

On Tue Mar 14 17:22:36 2006, KWILLIAMS wrote: Show quoted text
Adam and I reviewed this issue today and determined: #1 Module::Install does have this bug wrt using Module::Build #2 ExtUtils::MakeMaker has a bug wrt a missing "NAME" #3 Module::Build should create a .packlist (which means #1 would be moot) Overview: ------------------------ We're using ExtUtils::Installed as the definitive reference here. Unfortunately, ExtUtils::Install::install() does not define a canonical .packlist location (it expects the caller to pass it an explicit filename.) But, given that the modules() method is not named "distros", we have decided that ExtUtils::Installed is expecting to find .packlist files under a directory such as the following (in actuality, it does File::Find on all of @INC -- but it assigns what it finds to module names *as if* it had used this random-access scheme.) ($module_path = $module_name) =~ s#::#/#g; That is, a user expects to get an answer with "my $packlist = $inst->packlist('Foo::Bar')", not 'Foo-Bar'. Essentially, we determined that the following should never yield output: perl -e 'use ExtUtils::Installed; my $i = ExtUtils::Installed->new; print join("\n", $i->modules, ""); ' | grep \- (XML-DOM, Pod-Tests, rpm-build-perl, libintl-perl, libxml-perl, ...) While the foo-perl dists are a bit of a sticking point, the majority of distros stick to the convention of '($dist = $module) =~ s/::/-/g'. The cases where ExtUtils::Installed won't work appear to be those where the author has incorrectly set the name parameter to "Foo-Bar" instead of "Foo::Bar". Aside: While this might best be solved with wrist-slapping, I think we need to normalize the 'NAME' parameter to have no '-' characters. Note that Module::Build will complain "Can't find file lib/Foo-Bar.pm to determine version", which sort-of covers the common "oops" case. Definitions: ------------------------ I'll use the M::B parameter names in the rest of this description. $module_name := Foo::Bar (NAME parameter in EU::MM) $dist_name := Foo-Bar (DISTNAME in EU::MM) Desired Behavior: ------------------------ 1. Given a $module_name, .packlist goes at ($path = $module_name) =~ s#::#/#g; 2. Given only $dist_name, pretend ($module_name = $dist_name) =~ s/-/::/g; goto(1) Current situation: ------------------------ Module::Build currently does nothing in case (2). ExtUtils::MakeMaker currently uses the directory name in absence of $module_name ('NAME'), the directory name ends up being $dist_name in most cases, but it should try $dist_name first (if that value is defined) because of things like: on win32 saying "Warning: Guessing NAME [AUTHEN~1] from current directory name." Module::Install implements the desired behavior when running from Makefile.PL because it passes EU::MM NAME => $module_name (where it determined $module_name from $dist_name as above.) When running from Build.PL, it does *not* pass this M::B this same information -- module_name => $module_name. See Ken's comment about "extend the same courtesy". However, see below. Suggested Implementation: ------------------------ Toolkits are strongly encouraged to prefer case (1) and warn/slap the author accordingly at `build|make dist` time if module_name is improperly formatted or missing. Module::Build should die() at `build dist` time if $module_name =~ m/-/, but at install time should $module_name =~ s/-/::/g for purposes of installing a .packlist. EU::MM should probably do something similar. Module::Install doesn't need to do anything if Module::Build implements the above behavior.