| Subject: | -w and -V option issues (and suggested fixes) |
| Date: | Thu, 9 Mar 2006 21:14:23 -0800 |
| To: | <bug-activitymail [...] rt.cpan.org> |
| From: | "George Pavlov" <gpavlov [...] mynewplace.com> |
David,
I just started using activity mail and mostly love it, except for a
couple of little things:
1. it does not seem to handle files with spaces and other funny
characters in them when creating an HTML link to the file (in
ViewCVS/ViewVC) with the -w option. My simplistic way of fixing it was
to add this line in the two appropriate places (right after $url is
declared) -- not sure if this covers all inappropriate characters (it
does cover the ones in my repository):
$url =~ s/([() &])/sprintf("%%%02X", ord($1))/seg;
2. when the -V option is used the script appends the following to the
file name in the url it composes: ".diff?r1=1.1&r2=1.2". I am not sure
the ".diff" part is necessary -- in ViewVC either works fine. The
problem is that if the ".diff" is present all further links on the
ViewVC page fail with Python errors. For example the "revision log" link
becomes ...filename.java.diff?view=log#rev1.2, which is NOT valid. This
might have something to do with a change of behavior in ViewVC (I am
running last night's build, version 1.0), but since dropping the ".diff"
works just as well for the diff page maybe that is a better way to go?
Thanks for a very useful piece of code!
George