Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 17964
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: thaljef [...] cpan.org
Requestors: lallip [...] cs.rpi.edu
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.14
Fixed in: 0.15



Subject: insists my code is not tidy
Here is a transcript of a recent session: $ perltidy -b file.pl $ perlcritic -1 file.pl Code is not tidy at line 1, column 1. See page 33 of PBP. (Severity: 1) No modifications were made to the file between being tidy'd and being criticised. I don't know what standards are applied when determining whether or not code is tidy, but they don't seem to match the perltidy program itself. Paul Lalli
On Fri Mar 03 12:19:42 2006, guest wrote: Show quoted text
> Here is a transcript of a recent session: > $ perltidy -b file.pl > $ perlcritic -1 file.pl > Code is not tidy at line 1, column 1. See page 33 of PBP.
(Severity: 1) Show quoted text
> > No modifications were made to the file between being tidy'd and being > criticised. I don't know what standards are applied when determining > whether or not code is tidy, but they don't seem to match the > perltidy program itself.
Perl::Critic just runs the code through Perl::Tidy and does a literal comparison to the original. It is possible that Perl::Tidy isn't completely stable (i.e. rerunning doesn't produce the same output). I haven't been able to reproduce the problem. Would you mind sending me your file (before and after perltidy) and your .perltidyrc file (if you use one)? Also, could you identify which version of Perl::Tidy you have? Thanks. -Jeff
CC: lallip [...] cs.rpi.edu
Subject: RE: [rt.cpan.org #17964] insists my code is not tidy
Date: Mon, 06 Mar 2006 08:05:57 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: "Lalli, Paul D" <paul.d.lalli [...] bankofamerica.com>
Jeffrey, I regret that I do not have the original un-tidy version of the file, as I used the -b option (repeatedly) while trying to figure out this issue. The version that has been run through perltidy is attached (file renamed to a .txt to avoid being stripped by my server's filters...). Versions of the two modules: $ perl -MPerl::Tidy -MPerl::Critic -le'print for $Perl::Tidy::VERSION, $Perl::Critic::VERSION' 20031021 0.14 I cannot seem to find a .perltidyrc file anywhere on my system. Paul Lalli Show quoted text
> -----Original Message----- > From: Jeffrey Thalhammer via RT [mailto:bug-Perl-Critic@rt.cpan.org] > Sent: Saturday, March 04, 2006 2:22 AM > To: lallip@cs.rpi.edu > Subject: [rt.cpan.org #17964] insists my code is not tidy > > > On Fri Mar 03 12:19:42 2006, guest wrote:
> > Here is a transcript of a recent session: > > $ perltidy -b file.pl > > $ perlcritic -1 file.pl > > Code is not tidy at line 1, column 1. See page 33 of PBP.
> (Severity: 1)
> > > > No modifications were made to the file between being tidy'd
> and being
> > criticised. I don't know what standards are applied when
> determining
> > whether or not code is tidy, but they don't seem to match the > > perltidy program itself.
> > Perl::Critic just runs the code through Perl::Tidy and does a literal > comparison to the original. It is possible that Perl::Tidy isn't > completely stable (i.e. rerunning doesn't produce the same > output). I > haven't been able to reproduce the problem. Would you mind > sending me > your file (before and after perltidy) and your .perltidyrc file (if > you use one)? Also, could you identify which version of Perl::Tidy > you have? Thanks. > > -Jeff > > > >

Message body is not shown because sender requested not to inline it.

From: thaljef [...] cpan.org
I think I finally found the problem. A fix will be included in Perl::Critic version 0.15, which will be released this weekend. Thanks for you patience. -Jeff