| Subject: | module misnamed? a no-op on Windows |
Hi Adam,
The module docs (and name) could be clearer that this is actually looking for an X server
display (or will this be extended to other windowing interfaces?).
In particular, there's an unhelpful (and silent) no-op for Windows users:
# Get rid of Win32 and existing DISPLAY cases
return 1 if $^O eq 'MSWin32';
Think this should be a failing check, and you should still be checking for an X server on
Windows (e.g. cygwin or Exceed).
I noticed Wx mentioned in the POD (but not referenced in the display checks). Wx requires X
on unix, but there are native (non-X) versions available on Windows and Mac. So would be
nice to have a better cross-platform example to test :-D.
Lastly, this module also installs successfully if a DISPLAY env is set :
return 1 if $ENV{DISPLAY};
Would be good to include a real test as part of the install (e.g. try fire up something which
should be available under X, like 'xedit'?)
Cheers,
Stephen