| Subject: | Net-eBay |
| Date: | Wed, 1 Mar 2006 18:19:41 -0800 |
| To: | bug-net-ebay [...] rt.cpan.org |
| From: | Scott Kister <scott [...] skister.com> |
Igor, thanks for writing this module, a few comments.
Very minor, but this comment is wrong.
# We use eBay Legacy API (expires in summer of 2006) by default.
$hash->{defaults} = { API => 2, compatibility => 415, timeout => 50 };
use XML::Dumper;
is this needed? I had to download the module from CPAN to get
Net::eBay to work, and I didn't see where it was used.
In submitRequest, I would like it to return XML, not a hash. I have
one script that does the fetching, it writes the results to a file,
and another script reads and processes that.
I could go from xml -> hash -> xml -> hash, but that does a lot of
extra work, and may not generate the same result.
Can you add an option to allow submitRequest to return $res->content
directly instead of running it through XMLin first?
Or another way which would keep backwards compatibility would be to
rename submitRequest to submitRequestXML, then have submitRequest do
my $xml = submitRequestXML(...);
$@ = "";
my $result = undef;
eval {
$result = XMLin( $xml );
#print "perl result=$result.\n";
};
return $result if $result;
print STDERR "Error parsing XML ($@). \n";
return $xml;
Thanks, Scott