Bug #17915 for Net-Domain-TLD: Please resurrect the OO interface and test suite

Wed Mar 01 08:01:15 2006 bricas [...] cpan.org - Ticket created

Subject:

Please resurrect the OO interface and test suite

Although it is mentioned in the "Changes" file that, from versions 1.63 onward, the OO interface has been removed and that we can use an old version to get it back -- this seriously breaks new installations of modules that depends on Net::Domain::TLD. Case in point: http://use.perl.org/~LTjake/journal/ To summarize: Email::Store needs Net::Domain::TLD deep down in the chain (via Email::Valid), but the error returned doesn't make much sense (due to the levels of indirection that I have to deal with in the application). Also, Ricardo Signes (RJBS) released version 1.62 which included a great test suite which would ensure that future revisions could be regression tested. Following versions completely removed the test suite in favor of a n "initialization" test alone. I'm not sure what your rationale behind completely breaking the module's API and test suite could be, but I'd be happy to listen.

Wed Mar 01 12:41:15 2006 Guest - Correspondence added

From:

alex.pavlovic [...] taskforce-1.com

Both Ricardo and myself have agreed that OO interface be removed. It's clumsy and not needed for this type of module. The test suite you mentioned consists of couple of files that never got added to the distribution, so this may be an error on my part. I will talk to Ricardo further about this and look into bringing the OO interface back as well as some new features. Thank you for your input. On Wed Mar 01 08:01:15 2006, BRICAS wrote: Show quoted text

> Although it is mentioned in the "Changes" file that, from versions

1.63 Show quoted text

> onward, the OO interface has been removed and that we can use an old > version to get it back -- this seriously breaks new installations of > modules that depends on Net::Domain::TLD. > > Case in point: http://use.perl.org/~LTjake/journal/ > > To summarize: Email::Store needs Net::Domain::TLD deep down in the

chain Show quoted text

> (via Email::Valid), but the error returned doesn't make much sense

(due Show quoted text

> to the levels of indirection that I have to deal with in the

application). Show quoted text

> > Also, Ricardo Signes (RJBS) released version 1.62 which included a

great Show quoted text

> test suite which would ensure that future revisions could be

regression Show quoted text

> tested. Following versions completely removed the test suite in

favor of Show quoted text

> a n "initialization" test alone. > > I'm not sure what your rationale behind completely breaking the

module's Show quoted text

> API and test suite could be, but I'd be happy to listen.

Wed Mar 01 12:41:17 2006 The RT System itself - Status changed from 'new' to 'open'

Wed Mar 01 12:49:46 2006 Guest - Correspondence added

From:

alex.pavlovic [...] taskforce-1.com

On Wed Mar 01 08:01:15 2006, BRICAS wrote: Show quoted text

> I'm not sure what your rationale behind completely breaking the

module's Show quoted text

> API and test suite could be, but I'd be happy to listen.

Also look under the Changes for 1.63, there were significant internal changes made to make some of the things work properly. Code had subroutines that did not work as expected from the documentation. Ricardo has informed me at that time that he started work on something but never got it finished. These features however may become available in the next release.

Tue Dec 11 14:43:20 2007 alexp [...] cpan.org - Correspondence added

New version has been uploaded.

Tue Dec 11 14:43:27 2007 alexp [...] cpan.org - Status changed from 'open' to 'resolved'