Skip Menu |

This queue is for tickets about the Log-Log4perl CPAN distribution.

Report information
The Basics
Id: 17912
Status: resolved
Priority: 0/
Queue: Log-Log4perl

People
Owner: Nobody in particular
Requestors: clkao [...] clkao.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: update test to use skip_all
to make stderr quiet.
Subject: logger-test.patch
=== t/034DBI.t ================================================================== --- t/034DBI.t (revision 52567) +++ t/034DBI.t (local) @@ -3,7 +3,7 @@ # Kevin Goess <cpan@goess.org> ########################################### -use Test; +use Test::More; use Log::Log4perl; our $no_DBD; @@ -17,20 +17,12 @@ #die "" if $SQL::Statement::VERSION < 1.005; }; if ($@) { - print STDERR "DBD::CSV or SQL::Statement 1.005 not installed, skipping tests\n"; - $no_DBD = 1; - plan tests => 1; + plan skip_all => "DBD::CSV or SQL::Statement 1.005 not installed, skipping tests\n"; }else{ plan tests => 15; } } -if ($no_DBD){ - ok(1); - exit(0); -} - - require DBI; my $dbh = DBI->connect('DBI:CSV:f_dir=t/tmp','testuser','testpw',{ PrintError => 1 });
Patch applied. It broke a couple of cases because of different behaviour of Test's and Test::More's ok() functions. Fixes applied. Thanks for the patch! -- Mike