Bug #17828 for HTML-Mason: Bug in Interp.pm causes test to fail on Windows

Okay - its really a bug in Windows, but... Interp.pm's remove object directory method incorrectly assumes that you can rename foo to bar, where foo and bar are both existing directories. On Unix, this helpfully puts foo inside of bar... On windows, it fails. The following patch will address this issue: *** Interp.pm Thu Feb 2 13:01:13 2006 --- lib/HTML/Mason/Interp.pm Tue Jan 3 12:01:00 2006 *************** sub remove_object_files *** 553,559 **** my $object_dir = $self->object_dir; if (-d $object_dir) { my $temp_dir = File::Temp::tempdir(DIR => $self->data_dir); ! rename($object_dir, File::Spec->catdir($temp_dir, "target") ) or die "could not rename '$object_dir' to '$temp_dir': $@"; $self->_make_object_dir(); rmtree($temp_dir); --- 553,559 ---- my $object_dir = $self->object_dir; if (-d $object_dir) { my $temp_dir = File::Temp::tempdir(DIR => $self->data_dir); ! rename($object_dir, $temp_dir) or die "could not rename '$object_dir' to '$temp_dir': $@"; $self->_make_object_dir(); rmtree($temp_dir);

perl v5.8.7 built for MSWin32-x86-multi-thread Mason test error: C:\2\HTML-Mason-1.32>nmake test Microsoft (R) Program Maintenance Utility Version 1.50 Copyright (c) Microsoft Corp 1988-94. All rights reserved. c:\Perl\bin\perl.exe Build --makefile_env_macros 1 test Converting custom POD tags in files under blib t\01-syntax...................ok t\01a-comp-calls..............ok t\02-sections.................ok t\02a-filter..................ok t\04-misc.....................ok t\05-request..................ok t\06-compiler.................ok t\06a-compiler_obj............ok t\07-interp...................ok t\07a-interp-mcr..............ok t\07b-interp-static-source....ok 2/6 t\07b-interp-static-source....NOK 3# Failed test 'change_component_with_stati_source_touch_file' # in C:\2\HTML-Mason-1.32\blib\lib/HTML/Mason/Tests.pm at line 559. t\07b-interp-static-source....ok 4/6# Looks like you failed 1 test of 6. t\07b-interp-static-source....dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 3 Failed 1/6 tests, 83.33% okay t\08-ah.......................skipped all skipped: no reason given t\09-component................ok t\09a-comp_content............ok t\10-cache....................ok t\10a-cache-1.0x..............ok t\11-inherit..................ok t\12-taint....................ok t\13-errors...................ok t\14-cgi......................ok t\14a-fake_apache.............ok t\15-subclass.................ok t\16-live_cgi.................skipped all skipped: no reason given t\17-print....................ok t\18-leak.....................ok t\19-subrequest...............ok t\20-plugins..................ok t\21-escapes..................ok t\99-pod......................ok Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t\07b-interp-static-source.t 1 256 6 1 16.67% 3 2 tests skipped. Failed 1/29 test scripts, 96.55% okay. 1/512 subtests failed, 99.80% okay. NMAKE : fatal error U1077: 'C:\WINDOWS\system32\cmd.exe' : return code '0xff' Stop.