Skip Menu |

This queue is for tickets about the CPAN CPAN distribution.

Report information
The Basics
Id: 17746
Status: resolved
Priority: 0/
Queue: CPAN

People
Owner: Nobody in particular
Requestors: adamk [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.85
Fixed in: (no value)



Subject: Signature tests fail on Win32
OK, more problems. This time it's with what is probably a "standard" signature test you use all the time. Not entirely sure what's going on here. CPAN.pm: Going to build A/AN/ANDK/CPAN-1.85.tar.gz Checking if your kit is complete... Looks good Writing Makefile for CPAN Use of uninitialized value in concatenation (.) or string at c:/vanilla-perl/per l/lib/ExtUtils/MakeMaker.pm line 881. cp lib/CPAN/Version.pm blib\lib\CPAN\Version.pm cp lib/CPAN.pm blib\lib\CPAN.pm cp lib/CPAN/Admin.pm blib\lib\CPAN\Admin.pm cp lib/CPAN/Tarzip.pm blib\lib\CPAN\Tarzip.pm cp lib/CPAN/Debug.pm blib\lib\CPAN\Debug.pm cp lib/CPAN/HandleConfig.pm blib\lib\CPAN\HandleConfig.pm cp lib/CPAN/Nox.pm blib\lib\CPAN\Nox.pm cp lib/CPAN/FirstTime.pm blib\lib\CPAN\FirstTime.pm C:\vanilla-perl\perl\bin\perl.exe -MExtUtils::Command -e cp scripts/cpan blib\sc ript\cpan pl2bat.bat blib\script\cpan C:\vanilla-perl\bin\dmake.EXE -- OK Running make test C:\vanilla-perl\perl\bin\perl.exe -MExtUtils::Command -e cp scripts/cpan blib\sc ript\cpan pl2bat.bat blib\script\cpan C:\vanilla-perl\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0 , 'blib\lib', 'blib\arch')" t/*.t t/00signature.....'gpg' is not recognized as an internal or external command, operable program or batch file. Cannot use GnuPG or Crypt::OpenPGP, please install either one first! --- SIGNATURE Mon Feb 20 04:02:31 2006 +++ (current) Mon Feb 20 23:24:20 2006 @@ -9,7 +9,7 @@ SHA1 37e858c51409a297ef5d3fb35dc57cd3b57f9a4d PAUSE2003.pub SHA1 af016003ad503ed078c5f8254521d13a3e0c494f PAUSE2005.pub SHA1 9eb4a605d56bb6659801ca89910c61ab4ee4a25c README -SHA1 b715529241216139f74cf4856b502ed75778b788 Todo +SHA1 c43d50e51ad5a747cb52845a403f155bcd292f7b Todo SHA1 efbe8e6882a2caa0d741b113959a706830ab5882 inc/Test/Builder.pm SHA1 ae1d68262bedc2475e2c6fd478d99b259b4fb109 inc/Test/More.pm SHA1 f015857dfb72fcecd43867ef89f0b7ed8f76b838 lib/CPAN.pm ==> MISMATCHED content between SIGNATURE and distribution files! <== t/00signature.....FAILED test 1 Failed 1/1 tests, 0.00% okay t/01loadme........ok t/02nox...........ok t/03pkgs..........ok t/10version.......ok t/11mirroredby....ok t/30shell......... Skipping tests! If you want to run the test please set environment variable $CPAN_RUN_SHELL_TEST to 1. Pls try it on your box and inform me if it works skipped all skipped: test is only validated on linux t/50pod...........skipped all skipped: Test::Pod 1.00 required for testing POD Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/00signature.t 1 1 100.00% 1 2 tests skipped. Failed 1/8 test scripts, 87.50% okay. 1/68 subtests failed, 98.53% okay. dmake.EXE: Error code 255, while making 'test_dynamic' C:\vanilla-perl\bin\dmake.EXE test -- NOT OK Running make install make test had returned bad status, won't install without force Show quoted text
cpan>
Subject: Re: [rt.cpan.org #17746] Signature tests fail on Win32
Date: Mon, 20 Feb 2006 20:49:22 +0100
To: bug-CPAN [...] rt.cpan.org
From: andreas.koenig.gmwojprw [...] franz.ak.mind.de (Andreas J. Koenig)
Show quoted text
>>>>> On Mon, 20 Feb 2006 07:33:44 -0500 (EST), " via RT" <bug-CPAN@rt.cpan.org> said:
Show quoted text
> Mon Feb 20 07:33:43 2006: Request 17746 was acted upon. > Transaction: Ticket created by ADAMK > Queue: CPAN > Subject: Signature tests fail on Win32 > Owner: Nobody > Requestors: ADAMK@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=17746 >
Show quoted text
> OK, more problems.
Show quoted text
> This time it's with what is probably a "standard" signature test you use > all the time. Not entirely sure what's going on here.
Yes, the sigature test is taken from the Module::Signature manpage. Show quoted text
> CPAN.pm: Going to build A/AN/ANDK/CPAN-1.85.tar.gz
Show quoted text
> Checking if your kit is complete... > [...]
Show quoted text
> t/00signature.....'gpg' is not recognized as an internal or external > command, > operable program or batch file. > Cannot use GnuPG or Crypt::OpenPGP, please install either one first!
This seems the relevant error message, all the rest below seems bogus to me. I have verified the following: get CPAN-1.85.tar.gz from CPAN and do: tar xvzf CPAN-1.85.tar.gz cd CPAN-1.85 cpansign -v This gives on Linux ==> Signature verified OK! <== But of course it cannot give that on a system with neither gpg nor Crypt::OpenPGP installed. So if you could investigate a little more, you could probably turn this into a bugreport for Module::Signature??? -- andreas
OK, it passes ok on CPAN 1.84, then fails on 1.85, and still fails on 1.86. So I'm not sure how, but maybe you added something to Todo between 1.84 and 1.85 that caused a problem with some of the newline logic? (audreyt's suggestion) Otherwise she has no idea and says "it's your code" :) If I copy the extracted Todo file over to Unix and run sha1sum it gives the correct value. But 00signature.t on the Win32 box gives the wrong value. So... 1. Confirm the file is extracting correctly, and is unmodified. I ran my newline fixer-upper program over it, and it didn't complain, so that seems to be ok. Because it's dead in both 1.85 and 1.86 it can't be a problem being a specific size. Removing the specific additional lines from 1.85 to give me the same thing as 1.84 does emit the correct same thing as 1.84. So whatever it is, it's definitely in your Todo entries between 1.84 and 1.85. hrm... (time passes) AHA! OK, got it # CHECKSUM_STATUS NIL -- distro not in CHECKSUMS file That specific line in the Todo file has the following at the end of the line... 000001b0h: 20 6E 6F 74 20 69 6E 20 43 48 45 43 4B 53 55 4D ; not in CHECKSUM 000001c0h: 53 20 66 69 6C 65 0D 0A 0A 09 69 6E 20 74 68 65 ; S file....in the 000001d0h: 20 22 64 22 20 6F 75 74 70 75 74 20 62 75 74 20 ; "d" output but Note, specifically the 0D 0A 0A! That 0D most certainly does NOT belong there. And that, via the binmode crlf whateverfuckitis, is causing the specific problem in generating the digest. Fix that, and it should all be hunky dorey.