Skip Menu |

This queue is for tickets about the FindBin-libs CPAN distribution.

Report information
The Basics
Id: 17730
Status: resolved
Priority: 0/
Queue: FindBin-libs

People
Owner: Nobody in particular
Requestors: gyles19 [...] visi.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.20
Fixed in: 1.20



Subject: Those spurious warnings from File::Spec
I find the spurious warnings coming from File::Spec very annoying. I traced it back to FindBin::libs making a call to File::Spec::catpath without providing the required filename parameter. I wrote a test to detect the behavior and prove when the patch fixes it. I have attached a unified diff patch file and the test file. This shows the problem using 'make test' on linux, and with 'prove' and 'perl'. I also updated the POD and fixed a typo and a POD format error. I verified things with: make test # barfs cd lib/Findbin patch <patch cd ../.. make make test # fixed Red Hat 7.2, perl 5.8.8
Subject: 04.t
#! perl -w use Test::More ( tests => 2) ; use Test::NoWarnings; use FindBin::libs; ok(1);
Subject: patch
Download patch
application/octet-stream 1.8k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #17730] Those spurious warnings from File::Spec
Date: Mon, 27 Feb 2006 12:43:43 -0500
To: bug-FindBin-libs [...] rt.cpan.org, undisclosed-recipients [...] wrkhors.com
From: Steven Lembark <lembark [...] wrkhors.com>
-- Guest via RT <bug-FindBin-libs@rt.cpan.org> Show quoted text
> > Sat Feb 18 14:47:54 2006: Request 17730 was acted upon. > Transaction: Ticket created by guest > Queue: FindBin-libs > Subject: Those spurious warnings from File::Spec > Owner: Nobody > Requestors: gyles19@visi.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=17730 > > > > I find the spurious warnings coming from File::Spec very annoying. I > traced it back to FindBin::libs making a call to File::Spec::catpath > without providing the required filename parameter. > > I wrote a test to detect the behavior and prove when the patch fixes it. > > I have attached a unified diff patch file and the test file. This shows > the problem using 'make test' on linux, and with 'prove' and 'perl'. > > I also updated the POD and fixed a typo and a POD format error. > > I verified things with: > > make test # barfs > cd lib/Findbin > patch <patch > cd ../.. > make > make test # fixed > > Red Hat 7.2, perl 5.8.8
thanks, it was a bogus paren: ( catpath $vol, ( catdir @dirpath , $base ) ) should've been: ( catpath $vol, ( catdir @dirpath ), $base ) The odd thing I found was that the error only showed up with make; prove and 'perl -d' didn't show the error. -- Steven Lembark 85-09 90th Street Workhorse Computing Woodhaven, NY 11421 lembark@wrkhors.com 1 888 359 3508
should've closed this as resolved the first time around...