Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 17694
Status: resolved
Priority: 0/
Queue: Net-DNS
People
Owner: Nobody in particular
Requestors: dean [...] cs.serenevy.net
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in:
  • 0.48
  • 0.55
Fixed in: (no value)
Attachments
patch
PGP.sig

History Show all quoted text
  Fri Feb 17 07:15:46 2006 Guest - Ticket created
Subject: typesbyval( 0 ) issues 'Argument "" isn't numeric in numeric gt (>)'
In Net/DNS.pm typesbyval strips leading zeroes from the value. This causes a problem when the value is zero. This is a one line fix, patch against 0.55 attached.
Subject: patch
Download patch
application/octet-stream 441b

Message body not shown because it is not plain text.

  Fri Feb 17 07:48:48 2006 olaf [...] dacht.net - Correspondence added
Subject: Re: [rt.cpan.org #17694] typesbyval( 0 ) issues 'Argument "" isn't numeric in numeric gt (>)'
Date: Fri, 17 Feb 2006 13:47:28 +0100
To: bug-Net-DNS [...] rt.cpan.org
From: "Olaf M. Kolkman" <olaf [...] dacht.net>
Show quoted text
>
Show quoted text
> In Net/DNS.pm typesbyval strips leading zeroes from the value. This > causes a problem when the value is zero. This is a one line fix, patch > against 0.55 attached.
The regexp will strip all leading zeros but the last digit will match, even when it is a zero. Try print Net::DNS::typesbyval("0") and print Net::DNS::typesbyval ("0000") These will both return "SIGZERO". The error message is returned when the value you pass is undefined. I think it is better if we add: die "Net::DNS::typesbyval() argument is not defined" unless defined $val; Do correct me when misguided. --Olaf
Download PGP.sig
application/pgp-signature 227b

Message body not shown because it is not plain text.

  Fri Feb 17 07:48:50 2006 The RT System itself - Status changed from 'new' to 'open'
  Fri Feb 17 22:49:59 2006 dean [...] cs.serenevy.net - Correspondence added
Subject: Re: [rt.cpan.org #17694] typesbyval( 0 ) issues 'Argument "" isn't numeric in numeric gt (>)'
Date: Fri, 17 Feb 2006 22:49:18 -0500 (EST)
To: "Olaf M. Kolkman" <bug-Net-DNS [...] rt.cpan.org>
From: Dean Serenevy <dean [...] cs.serenevy.net>
Oh yes indeed. My installed version, 0.48, does have the problem with zero and I misread the current version. I can only console myself by the fact that a related bug was found due to my error. Thank you, Dean On Fri, 17 Feb 2006, Olaf M. Kolkman via RT wrote: Show quoted text
>> In Net/DNS.pm typesbyval strips leading zeroes from the value. This >> causes a problem when the value is zero. This is a one line fix, patch >> against 0.55 attached.
> > The regexp will strip all leading zeros but the last digit will > match, even when it is a zero. > > Try print Net::DNS::typesbyval("0") and print Net::DNS::typesbyval > ("0000") > > These will both return "SIGZERO". > > The error message is returned when the value you pass is undefined. > I think it is better if we add: > > die "Net::DNS::typesbyval() argument is not defined" unless > defined $val; > > Do correct me when misguided. > > --Olaf > >
  Sat Feb 18 04:55:25 2006 olaf [...] dacht.net - Correspondence added
Subject: Re: [rt.cpan.org #17694] typesbyval( 0 ) issues 'Argument "" isn't numeric in numeric gt (>)'
Date: Sat, 18 Feb 2006 10:54:19 +0100
To: bug-Net-DNS [...] rt.cpan.org
From: "Olaf M. Kolkman" <olaf [...] dacht.net>
On Feb 18, 2006, at 4:50 AM, dean@cs.serenevy.net via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=17694 > > > > Oh yes indeed. My installed version, 0.48, does have the problem > with zero > and I misread the current version. I can only console myself by the > fact > that a related bug was found due to my error.
>> >> die "Net::DNS::typesbyval() argument is not defined" unless >> defined $val; >>
Well... next version will check on undefined and catch it with a 'confess' :-) I do appreciate bug reports with patches so I'd like to give you some credit anyway... What's your last name Dean? --Olaf ------------------------------------------------------ Ik dacht net... heel even maar.
Download PGP.sig
application/pgp-signature 227b

Message body not shown because it is not plain text.

  Sat Feb 18 12:58:41 2006 dean [...] cs.serenevy.net - Correspondence added
Subject: Re: [rt.cpan.org #17694] typesbyval( 0 ) issues 'Argument "" isn't numeric in numeric gt (>)'
Date: Sat, 18 Feb 2006 12:57:57 -0500 (EST)
To: "Olaf M. Kolkman via RT" <bug-Net-DNS [...] rt.cpan.org>
From: Dean Serenevy <dean [...] cs.serenevy.net>
Thank you very much. I am Dean Serenevy. Good Day, Dean Show quoted text
> Well... next version will check on undefined and catch it with a > 'confess' > > :-) > > I do appreciate bug reports with patches so I'd like to give you some > credit anyway... What's your last name Dean? > > --Olaf > > ------------------------------------------------------ > Ik dacht net... heel even maar.
  Tue Apr 18 05:24:37 2006 OLAF [...] cpan.org - Status changed from 'open' to 'resolved'