Bug #17620 for HTML-Element-Library: element attributes in a different order for tests

Mon Feb 13 10:24:54 2006 BARBIE [...] cpan.org - Ticket created

Subject:

element attributes in a different order for tests

The attached file is the test run I tried. You'll note that the only failures related to specific string matching where the attributes are in a different order to those expected. The results are still valid and correct. I suggest you use some other method for validating whether the return values match what is expected. I assume somewhere in the mix there is a hash storing the elements/attributes, which you are expecting to always return data in a guaranteed order. Also could you include 'Params::Validate' and 'HTML::Element' in your Makefile.PL as these are missing from your prerequisites.

Subject:

audit.log

Download audit.log
application/octet-stream 58.8k

Message body not shown because it is not plain text.

Mon Feb 13 14:16:02 2006 metaperl@gmail.com - Correspondence added

CC:	barbie [...] missbarbell.co.uk
Subject:	Re: [rt.cpan.org #17620] element attributes in a different order for tests
Date:	Mon, 13 Feb 2006 11:14:09 -0800
To:	bug-HTML-Element-Library [...] rt.cpan.org
From:	Terrence Brannon <metaperl [...] gmail.com>

On 2/13/06, Barbie via RT <bug-HTML-Element-Library@rt.cpan.org> wrote: Show quoted text

> > The attached file is the test run I tried. You'll note that the only > failures related to specific string matching where the attributes are in > a different order to those expected. The results are still valid and > correct. I suggest you use some other method for validating whether the > return values match what is expected. I assume somewhere in the mix > there is a hash storing the elements/attributes, which you are expecting > to always return data in a guaranteed order.

Yes, in the svn trunk of HTML::Tree, the file HTML/Element.pm has a subroutine starttag() which builds the start tag and its attributes. On line 1858 of that subroutine you see this: for (sort keys %$self) { # predictable ordering and that forces the attributes to be in sorted order. It looks like my expectation file (*.exp) in the test suite is out of date. I just updated that file so that the attributes are in sorted order. The attached .tar.gz is going to CPAN now and should address the issue. I credited you in the AUTHOR section. Show quoted text

> > Also could you include 'Params::Validate' and 'HTML::Element' in your > Makefile.PL as these are missing from your prerequisites.

Thanks. I added Params::Validate. HTML::Element is part of the HTML::Tree distribution which is already included.

Download HTML-Element-Library-3.50.tar.gz
application/x-gzip 34.3k

Message body not shown because it is not plain text.

Mon Feb 13 14:16:04 2006 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 05 12:29:27 2011 metaperl [...] gmail.com - Correspondence added 60 min

Ok everything should be hunky-dory now.

Tue Jul 05 12:29:28 2011 metaperl [...] gmail.com - Status changed from 'open' to 'resolved'