Bug #17603 for DBD-SQLite: Never executed statements don't finalize

Sun Feb 12 17:25:21 2006 Guest - Ticket created

Subject:

Never executed statements don't finalize

Perl version: This is perl, v5.8.7 built for darwin-2level OS Version: Darwin 8.4.0 Darwin Kernel Version 8.4.0: Tue Jan 3 18:22:10 PST 2006; root:xnu-792.6.56.obj~1/RELEASE_PPC Power Macintosh powerpc Using DBD::SQLite 1.11 with local SQLite (not external library): If you prepare a statement and never execute it, it still counts are being an active statement handle even if you call finish on it. Simple example: my $dbh = DBI->connect('dbi:SQLite:foo.db') || die("Failed to open db"); my $f = $dbh->prepare("select 1"); $f->finish(); undef $f; $dbh->disconnect(); You still get: closing dbh with active statement handles Clearly we shouldn't get that warning...

Tue May 02 11:42:30 2006 SHLOMIF [...] cpan.org - Correspondence added

From:

Shlomi Fish <shlomif [...] iglu.org.il>

On Sun Feb 12 17:25:21 2006, guest wrote: Show quoted text

> Perl version: > > This is perl, v5.8.7 built for darwin-2level > > OS Version: > > Darwin 8.4.0 Darwin Kernel Version 8.4.0: Tue Jan 3 18:22:10 PST

2006; Show quoted text

> root:xnu-792.6.56.obj~1/RELEASE_PPC Power Macintosh powerpc > > Using DBD::SQLite 1.11 with local SQLite (not external library): > > If you prepare a statement and never execute it, it still counts are > being an active statement handle even if you call finish on it. > > Simple example: > > my $dbh = DBI->connect('dbi:SQLite:foo.db') || die("Failed to open

db"); Show quoted text

> > my $f = $dbh->prepare("select 1"); > $f->finish(); > undef $f; > > $dbh->disconnect(); > > You still get: > > closing dbh with active statement handles > > Clearly we shouldn't get that warning...

Hi the attached patch + extra files fixes this problem. It includeds a patch and two files that should be added to the dist.

Download issue-17603.tar.gz
application/x-tgz 1.8k

Message body not shown because it is not plain text.

Tue May 02 11:42:32 2006 The RT System itself - Status changed from 'new' to 'open'

Tue May 02 11:47:24 2006 SHLOMIF [...] cpan.org - Correspondence added

On Tue May 02 11:42:30 2006, SHLOMIF wrote: Show quoted text

> On Sun Feb 12 17:25:21 2006, guest wrote:

> > Perl version: > > > > This is perl, v5.8.7 built for darwin-2level > > > > OS Version: > > > > Darwin 8.4.0 Darwin Kernel Version 8.4.0: Tue Jan 3 18:22:10 PST

> 2006;

> > root:xnu-792.6.56.obj~1/RELEASE_PPC Power Macintosh powerpc > > > > Using DBD::SQLite 1.11 with local SQLite (not external library): > > > > If you prepare a statement and never execute it, it still counts

are Show quoted text

> > being an active statement handle even if you call finish on it. > > > > Simple example: > > > > my $dbh = DBI->connect('dbi:SQLite:foo.db') || die("Failed to open

> db");

> > > > my $f = $dbh->prepare("select 1"); > > $f->finish(); > > undef $f; > > > > $dbh->disconnect(); > > > > You still get: > > > > closing dbh with active statement handles > > > > Clearly we shouldn't get that warning...

> > Hi the attached patch + extra files fixes this problem. It includeds

a Show quoted text

> patch and two files that should be added to the dist. >

I should note that it isn't a complete patch, just one that allows one to call ->finish() on the statement handles to finalise them, and thus eliminate the warning.

Fri Sep 08 00:43:54 2006 msergeant [...] cpan.org - Correspondence added

Will be fixed in 1.13.

Fri Sep 08 00:43:56 2006 msergeant [...] cpan.org - Status changed from 'open' to 'resolved'