Skip Menu |

This queue is for tickets about the Regexp-Common CPAN distribution.

Report information
The Basics
Id: 17569
Status: resolved
Priority: 0/
Queue: Regexp-Common

People
Owner: Nobody in particular
Requestors: lhebblethwaite [...] transoft.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.120
Fixed in: (no value)



Subject: $RE{comment}{Pascal} fails to match "(*****)" as a valid comment.
$RE{comment}{Pascal} does not match "(*****)" as a valid comment. This is incorrect; it is valid. It seems that $RE{comment}{Pascal} needs to see a character other than "*" somewhere in the comment. That is, "(** **)" is correctly recognised as a comment. I attach a small test script to demonstrate the problem. FYI: I used the following re instead: /([(][*]|[{]).*?([}]|[*][)])/. I'm not sure that this does all that one in the module does, but it's sufficient for my purposes. My perl -v info is: This is perl, v5.8.7 built for MSWin32-x86-multi-thread (with 14 registered patches, see perl -V for more detail) Copyright 1987-2005, Larry Wall Binary build 815 [211909] provided by ActiveState http://www.ActiveState.com ActiveState is a division of Sophos. Built Nov 2 2005 08:44:52
Subject: pascal_comment_test.pl
use strict; use warnings; use Regexp::Common; testit("(*****)", " (*****) ", "(* This is a comment *)", " (* This is a comment *) ", "(*** **)", " (*** **) ", "(* *)"); sub testit { for my $text (@_) { print "Testing: $text\n"; if ($text =~ /$RE{comment}{Pascal}/) { print " Comment\n"; } else { print " Not comment\n"; } } }
This seems to have been fixed eons ago.
Subject: RE: [rt.cpan.org #17569] $RE{comment}{Pascal} fails to match "(*****)" as a valid comment.
Date: Sun, 17 Apr 2011 19:06:03 +0100
To: <bug-Regexp-Common [...] rt.cpan.org>
From: "Leigh Hebblethwaite" <lHebblethwaite [...] transoft.com>
Thanks. Leigh Hebblethwaite, Transoft, part of IRIS DD: +44 (0) 1753 778064 M: +44 (0) 7801 412331 Show quoted text
> -----Original Message----- > From: Abigail via RT [mailto:bug-Regexp-Common@rt.cpan.org] > Sent: 17 April 2011 15:13 > To: Leigh Hebblethwaite > Subject: [rt.cpan.org #17569] $RE{comment}{Pascal} fails to match > "(*****)" as a valid comment. > > <URL: https://rt.cpan.org/Ticket/Display.html?id=17569 > > > This seems to have been fixed eons ago.
-------------------------------------------------------------------------------------------------------------------------- This email and any attachment are intended only for the use of the individual or entity to which it is directed and may contain information which is confidential. Access, copying or re-use of information in or attached to this email by anyone else other than the intended recipient is strictly prohibited. If you have received this communication and you are not the intended recipient or the employee or agent responsible for delivering this email to the intended recipient, please inform IRIS on telephone number 01753 212200 and then delete this email and any attachments from your system. IRIS makes no representation or warranty as to the absence of viruses in this email or any attachments and we may monitor emails sent to and from our server. Any views or opinions presented in this email or attachment are solely those of the author and do not necessarily represent those of IRIS Software Group Limited, its parent, associates, subsidiaries or affiliates, unless otherwise expressly indicated. IRIS Software Group Limited is a Company registered in England and Wales under number 6294985 at Riding Court House, Datchet, Berkshire SL3 9JT VAT number 678 7928 53 -------------------------------------------------------------------------------------------------------------------------- This message has been scanned for malware by SurfControl plc. www.surfcontrol.com