Bug #17547 for HTTP-Server-Simple: HTTP::Server::Simple doesn't let PUT or DELETE

Wed Feb 08 18:39:39 2006 CDENT [...] cpan.org - Ticket created

Subject:

HTTP::Server::Simple doesn't let PUT or DELETE

Hey Jesse, I want to PUT and DELETE to an HTTP::Server::Simple, but I get stopped in _process_request at line 298: if ( $method !~ /^(?:GET|POST|HEAD)$/ ) { $self->bad_request; return; } any reason not to: if ( $method !~ /^(?:GET|POST|HEAD|PUT|DELETE)$/ ) { $self->bad_request; return; } Thanks.

Wed Feb 08 18:42:34 2006 jesse [...] fsck.com - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #17547] HTTP::Server::Simple doesn't let PUT or DELETE
Date:	Wed, 8 Feb 2006 18:42:27 -0500
To:	via RT <bug-HTTP-Server-Simple [...] rt.cpan.org>
From:	jesse <jesse [...] fsck.com>

Show quoted text

> Hey Jesse, I want to PUT and DELETE to an HTTP::Server::Simple, but I get stopped in > _process_request at line 298: > > if ( $method !~ /^(?:GET|POST|HEAD)$/ ) { > $self->bad_request; > return; > } > > any reason not to: > > if ( $method !~ /^(?:GET|POST|HEAD|PUT|DELETE)$/ ) { > $self->bad_request; > return; > }

No reason at all, but I'd rather break it out into a method called, say valid_http_verb or valid_http_method? That sound sane? (It should be easier to overload, but yes, that seems a sane change for the base server) Show quoted text

> > Thanks. >

--

Wed Feb 08 18:42:35 2006 The RT System itself - Status changed from 'new' to 'open'

Wed Feb 08 19:03:38 2006 cdent [...] burningchrome.com - Correspondence added

Subject:	Re: [rt.cpan.org #17547] HTTP::Server::Simple doesn't let PUT or DELETE
Date:	Wed, 8 Feb 2006 16:02:25 -0800 (PST)
To:	Jesse via RT <bug-HTTP-Server-Simple [...] rt.cpan.org>
From:	Chris Dent <cdent [...] burningchrome.com>

On Wed, 8 Feb 2006, Jesse via RT wrote: Show quoted text

> > any reason not to: > > > > if ( $method !~ /^(?:GET|POST|HEAD|PUT|DELETE)$/ ) { > > $self->bad_request; > > return; > > }

> > > No reason at all, but I'd rather break it out into a method called, say > valid_http_verb or valid_http_method? That sound sane?

valid_http_method sounds perfect -- Chris Dent http://burningchrome.com/~cdent/mt [...]

Wed Feb 08 19:10:26 2006 jesse [...] fsck.com - Correspondence added

Subject:	Re: [rt.cpan.org #17547] HTTP::Server::Simple doesn't let PUT or DELETE
Date:	Wed, 8 Feb 2006 19:10:21 -0500
To:	Chris Dent via RT <bug-HTTP-Server-Simple [...] rt.cpan.org>
From:	jesse <jesse [...] fsck.com>

If you're touching the code and coulde easily send the few lines of patch, it'd be much appreciated. I'm stuck in a couple other projects at the moment. But if the patch applies, I'll roll a new release lickidy-split.

Wed Feb 08 20:15:15 2006 cdent [...] burningchrome.com - Correspondence added

Subject:	Re: [rt.cpan.org #17547] HTTP::Server::Simple doesn't let PUT or DELETE
Date:	Wed, 8 Feb 2006 17:13:47 -0800 (PST)
To:	Jesse via RT <bug-HTTP-Server-Simple [...] rt.cpan.org>
From:	Chris Dent <cdent [...] burningchrome.com>

On Wed, 8 Feb 2006, Jesse via RT wrote: Show quoted text

> If you're touching the code and coulde easily send the few lines of > patch, it'd be much appreciated. I'm stuck in a couple other projects at > the moment. But if the patch applies, I'll roll a new release > lickidy-split.

Right on. It's attached. Does what I need it to do. Thanks -- Chris Dent http://burningchrome.com/~cdent/mt [...]

Message body is not shown because sender requested not to inline it.

Wed Feb 08 21:26:46 2006 jesse [...] fsck.com - Correspondence added

Subject:	Re: [rt.cpan.org #17547] HTTP::Server::Simple doesn't let PUT or DELETE
Date:	Wed, 8 Feb 2006 21:26:43 -0500
To:	Chris Dent via RT <bug-HTTP-Server-Simple [...] rt.cpan.org>
From:	jesse <jesse [...] fsck.com>

Thanks. Applied (slightly munged to eliminate duplication) and uploaded to CPAN as 0.18

Wed May 07 03:59:25 2008 rt.cpan [...] sartak.org - Status changed from 'open' to 'resolved'