Bug #17544 for CGI-Wiki-Formatter-Kwiki: Lacks full support for CGI::Kwiki::Formatter

Wed Feb 08 15:24:02 2006 neil [...] neely.cx - Ticket created

Subject:

Lacks full support for CGI::Kwiki::Formatter

I noticed in the source for CGI::Wiki::Formatter::Kwiki that you had explicitly overridden the process_order method of CGI::Kwiki::Formatter to disable several of its markup methods, notably including tables. After doing a little experimenting I could see why you made that choice, it appears that when using the full list of methods it mangles the output in strange and intersting ways. I tracked the cause of the mangling to this call: use CGI ":standard"; As near as I can track down your module does not actually use anything from that module set and it can be removed without any side effects. Once you comment out the 'use CGI ":standard";' line you can then remove the subroutine of process_order from your module, and it will then properly handle marking up the content using all markup methods of the CGI::Kwiki::Formatter module.

Wed Feb 08 15:36:55 2006 neil [...] neely.cx - Correspondence added

Attached output of: diff -u lib/CGI/Wiki/Formatter/Kwiki.orig lib/CGI/Wiki/Formatter/Kwiki.pm

--- lib/CGI/Wiki/Formatter/Kwiki.orig Tue Jun 15 08:52:43 2004 +++ lib/CGI/Wiki/Formatter/Kwiki.pm Wed Feb 8 13:32:31 2006 @@ -3,9 +3,8 @@ use strict; use vars qw( $VERSION @_links_found ); -$VERSION = '0.03'; +$VERSION = '0.04'; -use CGI ":standard"; use Carp qw(croak carp); use CGI::Kwiki::Formatter; @@ -141,23 +140,6 @@ # print STDERR "$method:\n".$self->combine_chunks($array)."\n\n\n\n\n----------\n"; } return $self->combine_chunks($array); -} - -# function -# table code - -sub process_order { - return qw( - header_1 header_2 header_3 header_4 header_5 header_6 - escape_html - lists horizontal_line - paragraph - named_http_link no_http_link http_link - no_mailto_link mailto_link - no_wiki_link force_wiki_link wiki_link - inline version negation - bold italic underscore - ); } 1;

Wed Feb 08 15:36:56 2006 The RT System itself - Status changed from 'new' to 'open'