Skip Menu |

This queue is for tickets about the Net-FTPSSL CPAN distribution.

Report information
The Basics
Id: 17537
Status: resolved
Priority: 0/
Queue: Net-FTPSSL

People
Owner: Nobody in particular
Requestors: dong.yan [...] morganstanley.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.04
Fixed in: 0.05



Subject: I am not sure if ascii transfers are handled correctly by the module
I don't have a non-unix server to test against, so this is only my guess. In an ascii transfer (including LIST and NLST), RFC959 calls for the sender to convert from local format to line+CRLF, and the receiver to convert from line+CRLF back to local format. I don't see any such conversions in the code.
From: kral [...] shenkong.org
On Mer. 08 Feb. 2006 12:03:22, guest wrote: Show quoted text
> I don't have a non-unix server to test against, so this is only my guess. > > In an ascii transfer (including LIST and NLST), RFC959 calls for the > sender to convert from local format to line+CRLF, and the receiver to > convert from line+CRLF back to local format. I don't see any such > conversions in the code.
I developed Net::FTPSSL mostly on a Win32 computer and tested it with a Win32 ftp server (TitanFTP). So, I'm pretty sure that there aren't problems with conversion. But thanks for your suggestion, I will make some tests about it anyway. -- kral
From: dong.yan [...] morganstanley.com
On Thu Feb 09 03:09:36 2006, KRAL wrote: Show quoted text
> On Mer. 08 Feb. 2006 12:03:22, guest wrote:
> > I don't have a non-unix server to test against, so this is only my
guess. Show quoted text
> > > > In an ascii transfer (including LIST and NLST), RFC959 calls for the > > sender to convert from local format to line+CRLF, and the receiver to > > convert from line+CRLF back to local format. I don't see any such > > conversions in the code.
> > I developed Net::FTPSSL mostly on a Win32 computer and tested it with a > Win32 ftp server (TitanFTP). So, I'm pretty sure that there aren't > problems with conversion. But thanks for your suggestion, I will make > some tests about it anyway. > > -- > kral
I believe the module works on Win32 because ftp uses CRLF during ascii transfers, and Win32 happens to also use CRLF as EOL. On unix the EOL is LF, and conversion is necessary. I was wrong in stating that I needed a non-unix server to test this ascii transfer behavior. It shouldn't matter which platform the server runs. I was able to confirm the incorrect ascii transfer behavior with this test case: 1) create a text file (EOL=LF) on the server (unix) 2) ascii transfer using Net::FTPSSL to the client (unix) 3) the file's left with CRLF at end of each line (this is incorrect)
This looks to be fixed in v0.05.