Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SVN-Notify CPAN distribution.

Report information
The Basics
Id: 17523
Status: rejected
Priority: 0/
Queue: SVN-Notify
People
Owner: Nobody in particular
Requestors: msl [...] calivia.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Feb 07 10:48:34 2006 msl [...] calivia.com - Ticket created
Subject: hangs with big diffs (6MB)
Date: Tue, 7 Feb 2006 16:48:23 +0100 (CET)
To: bug-svn-notify [...] rt.cpan.org
From: "Michael Steinmann" <msl [...] calivia.com>
I'm trying to put my /etc with a size of 38MB under SVN but --with-diff hangs the post-commit script at the initial commit. The initial commit goes through to SVN, but the post-commit hangs while diffing the changes. --attach-diff works fine (but doesn't look that nice ;-). The attached diff is about 6MB. -- mike #!/bin/sh REPOS="$1" REV="$2" PATH=/usr/bin:/bin HOST=`/bin/hostname` /usr/bin/svnnotify \ --repos-path "$REPOS" \ --revision "$REV" \ --svnlook /usr/bin/svnlook \ --to cm-list@example.com \ --from cm@$HOST.example.com \ --subject-prefix "CM - $HOST:" \ --subject-cx \ --handler HTML::ColorDiff \ --with-diff
  Tue Feb 07 16:00:31 2006 david [...] kineticode.com - Correspondence added
Subject: Re: [rt.cpan.org #17523] hangs with big diffs (6MB)
Date: Tue, 7 Feb 2006 12:59:26 -0800
To: bug-SVN-Notify [...] rt.cpan.org
From: David Wheeler <david [...] kineticode.com>
On Feb 7, 2006, at 07:48, Michael Steinmann via RT wrote: Show quoted text
> I'm trying to put my /etc with a size of 38MB under SVN but --with- > diff > hangs the post-commit script at the initial commit. > > The initial commit goes through to SVN, but the post-commit hangs > while > diffing the changes. --attach-diff works fine (but doesn't look > that nice > ;-). The attached diff is about 6MB.
How much memory do you have in this box? I suggest turning off the diff support until you're done changing the world. Best, David
  Tue Feb 07 16:00:32 2006 The RT System itself - Status changed from 'new' to 'open'
  Thu Feb 16 03:50:58 2006 Guest - Correspondence added
From: msl [...] calivia.com
On Di. 07. Feb. 2006, 16:00:31, david@kineticode.com wrote: Show quoted text
> On Feb 7, 2006, at 07:48, Michael Steinmann via RT wrote: >
> > I'm trying to put my /etc with a size of 38MB under SVN but --with- > > diff > > hangs the post-commit script at the initial commit. > > > > The initial commit goes through to SVN, but the post-commit hangs > > while > > diffing the changes. --attach-diff works fine (but doesn't look > > that nice > > ;-). The attached diff is about 6MB.
> > How much memory do you have in this box? I suggest turning off the > diff support until you're done changing the world. > > Best, > > David
It's a virtual machine with 512MB. I posted the bug more as a hint for others as it took me some time to figure out where and why the initial commit was hanging. Maybe the bug could be changed into a feature request where one could pass a size limit as an additional parameter; diffs bigger than this limit would be attached instead of included into the mail body. Thanks for the great software anyways. -- mike
  Fri Feb 17 15:03:46 2006 dwheeler [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #17523] hangs with big diffs (6MB)
Date: Fri, 17 Feb 2006 12:02:54 -0800
To: bug-SVN-Notify [...] rt.cpan.org
From: David Wheeler <dwheeler [...] cpan.org>
On Feb 16, 2006, at 00:50, Guest via RT wrote: Show quoted text
> Maybe the bug could be changed into a feature request where one could > pass a size limit as an additional parameter; diffs bigger than this > limit would be attached instead of included into the mail body.
I don't see how that would prevent svnnotify from hanging, since it has to do precisely the same amount of work, and will therefore use the same amount of RAM (there is little difference, programmatically, between inlining and attaching a diff, although there is likely a difference to your mail client!). Show quoted text
> Thanks for the great software anyways.
I'm glad so many people get use out of it. Best, David
  Tue Mar 27 02:54:07 2007 dwheeler [...] cpan.org - Correspondence added
On Thu Feb 16 03:50:58 2006, guest wrote: Show quoted text
> Maybe the bug could be changed into a feature request where one could > pass a size limit as an additional parameter; diffs bigger than this > limit would be attached instead of included into the mail body.
I did add the --max-diff-length option back in 2.54. Does that solve your problem? —David
  Wed Feb 06 14:14:35 2008 dwheeler [...] cpan.org - Severity Normal added
  Wed Feb 06 14:17:33 2008 dwheeler [...] cpan.org - Status changed from 'open' to 'rejected'