Bug #17385 for MIME-Lite-HTML: make test semi-panics

Tue Jan 31 02:46:05 2006 Guest - Ticket created

Subject:

make test semi-panics

When running make test, I am receiving semi-panics from the output. Running MIME-Lite-HTML-v1.21. Perl is v5.8.7. OS is CentOS 4.2 [root@talon1 MIME-Lite-HTML-1.21]# make test PERL_DL_NONLAZY=1 /usr/local/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01use..................ok t/20create_image_part....ok t/50generic..............semi-panic: attempt to dup freed string at /usr/src/MIME-Lite-HTML-1.21/blib/lib/MIME/Lite/HTML.pm line 657. t/50generic..............ok 1/190semi-panic: attempt to dup freed string at /usr/src/MIME-Lite-HTML-1.21/blib/lib/MIME/Lite/HTML.pm line 657. semi-panic: attempt to dup freed string at /usr/src/MIME-Lite-HTML-1.21/blib/lib/MIME/Lite/HTML.pm line 657. semi-panic: attempt to dup freed string at /usr/src/MIME-Lite-HTML-1.21/blib/lib/MIME/Lite/HTML.pm line 657. t/50generic..............ok 124/190semi-panic: attempt to dup freed string at /usr/src/MIME-Lite-HTML-1.21/blib/lib/MIME/Lite/HTML.pm line 657. semi-panic: attempt to dup freed string at /usr/src/MIME-Lite-HTML-1.21/blib/lib/MIME/Lite/HTML.pm line 657. t/50generic..............ok All tests successful. Files=3, Tests=195, 2 wallclock secs ( 1.58 cusr + 0.24 csys = 1.82 CPU)

Tue Jan 31 10:31:45 2006 Guest - Correspondence added

From:

Kevin A. McGrail

I've looked at the logic and it seems sound but by rewriting the logic, the error is gone but I believe the result is the same as the original intention. http://www.thoughtworthy.com/downloads/MIME-Lite-HTML-1.21-KAM.patch --- /usr/local/lib/perl5/site_perl/5.8.7/MIME/Lite/HTML.pm 2004-04-15 18:59:33.000000000 -0400 +++ /usr/src/MIME-Lite-HTML-1.21/blib/lib/MIME/Lite/HTML.pm 2006-01-31 10:24:41.000000000 -0500 @@ -653,8 +653,12 @@ #------------------------------------------------------------------------------ sub set_err { my($self,$error) = @_; + my (@array); print $error,"\n" if ($self->{_DEBUG}); - my @array = @{$self->{_ERRORS}} if ($self->{_ERRORS}); + + if ($self->{_ERRORS}) { + @array = @{$self->{_ERRORS}}; + } push @array, $error; $self->{_ERRORS} = \@array; return 1;

--- /usr/local/lib/perl5/site_perl/5.8.7/MIME/Lite/HTML.pm 2004-04-15 18:59:33.000000000 -0400 +++ /usr/src/MIME-Lite-HTML-1.21/blib/lib/MIME/Lite/HTML.pm 2006-01-31 10:24:41.000000000 -0500 @@ -653,8 +653,12 @@ #------------------------------------------------------------------------------ sub set_err { my($self,$error) = @_; + my (@array); print $error,"\n" if ($self->{_DEBUG}); - my @array = @{$self->{_ERRORS}} if ($self->{_ERRORS}); + + if ($self->{_ERRORS}) { + @array = @{$self->{_ERRORS}}; + } push @array, $error; $self->{_ERRORS} = \@array; return 1;

Tue Jan 31 10:31:46 2006 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 31 10:46:16 2006 Guest - Correspondence added

From:

Kevin A. McGrail

I patched the installed library rather than the source library so here is a second patch.

--- /usr/src/MIME-Lite-HTML-1.21/HTML.pm 2004-04-15 18:59:33.000000000 -0400 +++ HTML.pm 2006-01-31 10:42:16.000000000 -0500 @@ -653,8 +653,12 @@ #------------------------------------------------------------------------------ sub set_err { my($self,$error) = @_; + my (@array); print $error,"\n" if ($self->{_DEBUG}); - my @array = @{$self->{_ERRORS}} if ($self->{_ERRORS}); + + if ($self->{_ERRORS}) { + @array = @{$self->{_ERRORS}}; + } push @array, $error; $self->{_ERRORS} = \@array; return 1;

Wed Sep 06 10:47:21 2006 alian [...] alianwebserver.com - Correspondence added

On Tue Jan 31 10:46:16 2006, guest wrote: Show quoted text

> I patched the installed library rather than the source library so here > is a second patch.

Thank you, I patch it.

Wed Sep 06 10:54:32 2006 kevin.mcgrail [...] thoughtworthy.com - Correspondence added

Subject:	Re: [rt.cpan.org #17385] make test semi-panics
Date:	Wed, 6 Sep 2006 10:53:46 -0400
To:	<bug-MIME-Lite-HTML [...] rt.cpan.org>
From:	"Kevin A. McGrail" <kevin.mcgrail [...] thoughtworthy.com>

Happy to help. regards, KAM Show quoted text

----- Original Message ----- From: " via RT" <bug-MIME-Lite-HTML@rt.cpan.org> To: <kevin.mcgrail@thoughtworthy.com> Sent: Wednesday, September 06, 2006 10:47 AM Subject: [rt.cpan.org #17385] make test semi-panics

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=17385 > > > On Tue Jan 31 10:46:16 2006, guest wrote:

>> I patched the installed library rather than the source library so here >> is a second patch.

> > Thank you, I patch it. > >

Thu Sep 07 08:41:52 2006 alian [...] alianwebserver.com - Status changed from 'open' to 'resolved'

Thu Sep 07 08:41:53 2006 alian [...] alianwebserver.com - Fixed in 1.22 added