Skip Menu |

This queue is for tickets about the SVN-Web CPAN distribution.

Report information
The Basics
Id: 17350
Status: resolved
Priority: 0/
Queue: SVN-Web

People
Owner: Nobody in particular
Requestors: garrison [...] codefix.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.43
Fixed in: (no value)



Subject: SVN::Web mod_perl2 patch
I made some small changes to get SVN::Web running under mod_perl2 while still keeping mod_perl compatibility, I hope it is useful to you.
Subject: Web.pm.diff
*** Web.old Sun Jan 29 17:26:25 2006 --- Web.pm Sun Jan 29 17:22:29 2006 *************** *** 860,874 **** } sub handler { ! eval " ! use Apache::RequestRec (); ! use Apache::RequestUtil (); ! use Apache::RequestIO (); ! use Apache::Response (); ! use Apache::Const; ! use Apache::Constants; ! use Apache::Request; ! "; my $r = shift; eval "$r = Apache::Request->new($r)"; --- 860,886 ---- } sub handler { ! use mod_perl; ! use constant MP2 => $mod_perl::VERSION >= 1.99; ! BEGIN { ! if (MP2) { ! require Apache2::RequestRec; ! require Apache2::RequestUtil; ! require Apache2::RequestIO; ! require Apache2::Response; ! require Apache2::Request; ! require Apache2::Const; ! Apache2::Const->import(-compile => qw(OK DECLINED)); ! } else { ! require Apache::RequestRec; ! require Apache::RequestUtil; ! require Apache::RequestIO; ! require Apache::Response; ! require Apache::Request; ! require Apache::Constants; ! Apache::Constants->import(-compile => qw(OK DECLINED)); ! } ! } my $r = shift; eval "$r = Apache::Request->new($r)"; *************** *** 921,927 **** } mod_perl_output($cfg, $html); ! return &Apache::OK; } =head1 SEE ALSO --- 933,939 ---- } mod_perl_output($cfg, $html); ! return MP2 ? Apache2::Const::OK : Apache::Constants::OK; } =head1 SEE ALSO
Hi, On Sun Jan 29 17:39:52 2006, guest wrote: Show quoted text
> I made some small changes to get SVN::Web running under mod_perl2 while > still keeping mod_perl compatibility, I hope it is useful to you.
Thanks for the patch. I couldn't get it to pass the tests as supplied though, so I've made a couple of small changes. I've attached the changes, as a new patch. Could you try it out and let me know if it still works for you. Thanks, N
Download diff
application/octet-stream 1.3k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #17350] SVN::Web mod_perl2 patch
Date: Sun, 29 Jan 2006 18:57:48 -0500
To: bug-SVN-Web [...] rt.cpan.org
From: Garrison Hoffman <garrison [...] codefix.net>
via RT wrote: Show quoted text
> Thanks for the patch. I couldn't get it to pass the tests as supplied > though, so I've made a couple of small changes. I've attached the > changes, as a new patch. Could you try it out and let me know if it > still works for you.
Works great. Thanks ;) -- Show quoted text
__________________________________________________________________ Garrison Hoffman Codefix Consulting 1.718.210.3445 garrison@codefix.net http://codefix.net/ 1.866.456.0584
Variation applied as http://jc.ngo.org.uk/svnweb/jc/revision?rev=775, which will be in 0.44. Thanks for the patch.