Skip Menu |

This queue is for tickets about the CPAN CPAN distribution.

Report information
The Basics
Id: 17315
Status: resolved
Priority: 0/
Queue: CPAN

People
Owner: ANDK [...] cpan.org
Requestors: carl [...] fireartist.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.83
Fixed in: (no value)



Subject: cpan.pm not using values from cpan/config.pm
perl 5.8.8-RC1 built from source: mingw (gcc 3.4.5) winXP pro sp2 The system calls in CPAN.pm relevant to "./Build" are all hardcoded, rather than using the config value "mbuild_install_build_command", when available. Attached is a patch for CPAN.pm
Subject: CPAN.pm.diff
4729c4729,4732 < $system = "./Build $CPAN::Config->{mbuild_arg}"; --- > my($perl) = $self->perl or die "Couldn\'t find executable perl\n"; > my($mbuild_install_build_command) = $CPAN::Config->{'mbuild_install_build_command'} || > "$perl Build"; > $system = "$mbuild_install_build_command $CPAN::Config->{mbuild_arg}"; 5003c5006,5009 < $system = "./Build test"; --- > my($perl) = $self->perl or die "Couldn\'t find executable perl\n"; > my($mbuild_install_build_command) = $CPAN::Config->{'mbuild_install_build_command'} || > "$perl Build"; > $system = "$mbuild_install_build_command test"; 5044c5050,5053 < $system = "./Build clean"; --- > my($perl) = $self->perl or die "Couldn\'t find executable perl\n"; > my($mbuild_install_build_command) = $CPAN::Config->{'mbuild_install_build_command'} || > "$perl Build"; > $system = "$mbuild_install_build_command clean"; 5128a5138 > my($perl) = $self->perl or die "Couldn\'t find executable perl\n"; 5130c5140 < "./Build"; --- > "$perl Build";
mbuild_install_build_command is only meant for the *install* target. The other targets are intentionally coded as ./Build. So I'm sorry, I cannot accept this patch. I suppose the motivation for this patch is the same as in #17313, so I leave 17313 open and close this one. Please direct followups to 17313.