| Subject: | Net::LDAP::LDIF - small bug in new() |
I noticed in the new() sub of Net::LDAP::LDIF that the object is
initialised as:
my $self = {
changetype => "modify",
modify => 'add',
wrap => 78,
%opt,
fh => $fh,
file => "$file",
opened_fh => $opened_fh,
eof => 0,
write_count => ($mode eq 'a' and tell($fh) > 0) ? 1 : 0,
};
Noting the spelling of the "eof" attribute but later in the eof() sub:
sub eof {
my $self = shift;
my $eof = shift;
if ($eof) {
$self->{_eof} = $eof;
}
$self->{_eof};
}
There is an underscore there in the attribute "_eof".
I can see that this won't actually cause any problems with the code but
it did cause me a bit of confusion when reading the code.
Thanks,
Stephen Quinney