| Subject: | svnweb-install doesn't warn/die if copying files fails |
For easier diagnosis of pboins problem, it might be good to check the
return code of File::Copy::copy() in svnweb-install:
Instead of the following code:
if(-d $File::Find::name) {
mkdir $dst_path;
} else {
copy($File::Find::name, $dst_path);
}
use code with error checking and warnings:
if(-d $File::Find::name) {
mkdir $dst_path
or warn "Couldn't create '$dst_path': $!";
} else {
copy($File::Find::name, $dst_path)
or warn "Couldn't copy '$File::Find::name' to '$dst_path':
$!";
}
I think that could make it more obvious what actually goes wrong in RT
#16774