Skip Menu |

This queue is for tickets about the Catalyst-Plugin-Email-Page CPAN distribution.

Report information
The Basics
Id: 17248
Status: resolved
Worked: 15 min
Priority: 0/
Queue: Catalyst-Plugin-Email-Page
People
Owner: GHENRY [...] cpan.org
Requestors: DAKKAR [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Jan 24 13:25:08 2006 DAKKAR [...] cpan.org - Ticket created
Subject: The module poduces malformed URLS
The module (v. 0.24 and probably all others) produces URLs without escaping invalid characters. With the default configuration, it produces: 'mailto:webmaster@example.com?subject=User%20Report%20for http://...' The space after 'for' should be escaped, as should the characters in the "page URL". The 'construct_url' method should really use the 'URI::URL' module to create the URL, and the 'email_page_url' should then escape all the characters in /[<>'"]/ with their HTML character entity references.
  Tue Jan 24 14:13:48 2006 GHENRY [...] cpan.org - Given to GHENRY
  Tue Jan 24 14:14:22 2006 GHENRY [...] cpan.org - Status changed from 'new' to 'open'
  Tue Jan 24 15:35:18 2006 GHENRY [...] cpan.org - Correspondence added 5 min
On Tue Jan 24 13:25:08 2006, DAKKAR wrote: Show quoted text
> The module (v. 0.24 and probably all others) produces URLs without > escaping invalid characters. With the default configuration, it > produces: 'mailto:webmaster@example.com?subject=User%20Report%20for > http://...' > > The space after 'for' should be escaped, as should the characters in the > "page URL". > > The 'construct_url' method should really use the 'URI::URL' module to > create the URL, and the 'email_page_url' should then escape all the > characters in /[<>'"]/ with their HTML character entity references.
My first CPAN bug report!!! Many, many thanks for taking the time to report this and even look through my code. I appreciate your comments and will make the changes for the next release. Again, thanks for your time. Gavin.
  Tue Jan 24 15:35:42 2006 GHENRY [...] cpan.org - Subject changed from 'The module poduces malformed URLS' to 'The module produces malformed URLS'
  Tue Jan 24 15:36:18 2006 GHENRY [...] cpan.org - Severity Important changed to Critical
  Wed Jan 25 11:28:04 2006 GHENRY [...] cpan.org - TimeWorked changed from '5' to '15'
  Wed Jan 25 11:28:04 2006 GHENRY [...] cpan.org - Status changed from 'open' to 'resolved'