Skip Menu |

This queue is for tickets about the Config-General CPAN distribution.

Report information
The Basics
Id: 17150
Status: resolved
Priority: 0/
Queue: Config-General

People
Owner: tlinden [...] cpan.org
Requestors: florian [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.31
Fixed in: (no value)



Subject: make test: Failed 1/1 test scripts, 0.00% okay. -1/24 subtests failed, 104.17% okay.
The attached patch will allow make test to succeed again. HTH, Flo
Subject: run.t.diff
--- libconfig-general-perl-2.31.orig/t/run.t +++ libconfig-general-perl-2.31/t/run.t @@ -6,7 +6,7 @@ # # Under normal circumstances every test should succeed. -BEGIN { $| = 1; print "1..24\n";} +BEGIN { $| = 1; print "1..25\n";} use lib "blib/lib"; use Config::General; use Data::Dumper;
Sorry for the late reply - RT didn't notify me of new tickets. That's wrong - 'make test' runs 100%: scip@mutant: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/run....ok 1/24 .. ok # loading Config::General t/run....ok 2/24 ... ok # Nested block test ... ok # Array content test t/run....ok 3/24 ... ok # Here-document test t/run....ok 4/24 ... ok # Multiline option test t/run....ok 5/24 ... ok # Comment test t/run....ok 6/24 ... ok # Case insensitive block test t/run....ok 7/24 ... ok # Writing Config Hash to disk and compare with original t/run....ok 8/24 ... ok # Creating a new object from config file t/run....ok 9/24 ... ok # Creating a new object using the hash parameter way t/run....ok 10/24 .. ok # Creating a new object from a block t/run....ok 11/24 .. ok # Creating a new object from a sub block t/run....ok 12/24 .. ok # Getting values from the object t/run....ok 13/24 .. ok # Using keys() and values() t/run....ok 14/24 .. ok # Using AUTOLOAD methods t/run....ok 15/24 .. ok # Testing variable interpolation t/run....ok 16/24 .. ok # Testing value pre-setting using a hash t/run....ok 17/24 .. ok # Testing value pre-setting using a string t/run....ok 18/24 .. ok # Testing various otion/value assignment notations t/run....ok 19/24 .. ok # testing files() method t/run....ok 20/24 .. ok # prevented from loading relative cfgs without -IncludeRelative t/run....ok 21/24 .. ok # loaded relative to included files t/run....ok 22/2423 not ok .. ok # including multiple files via glob pattern with -IncludeGlob t/run....ok 23/24 .. ok # block and block name quoting t/run....ok All tests successful. Files=1, Tests=24, 7 wallclock secs ( 0.22 cusr + 0.02 csys = 0.24 CPU)
CC: Francesco Cecconi <francesco.cecconi [...] gmail.com>
Subject: Re: [rt.cpan.org #17150] make test: Failed 1/1 test scripts, 0.00% okay. -1/24 subtests failed, 104.17% okay.
Date: Fri, 23 Feb 2007 00:15:10 +0100
To: via RT <bug-Config-General [...] rt.cpan.org>
From: Florian Ernst <florian [...] uni-hd.de>
On Thu, Feb 22, 2007 at 04:56:00PM -0500, via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=17150 > > > Sorry for the late reply - RT didn't notify me of new tickets. > > That's wrong - 'make test' runs 100%: > [...]
Here it doesn't without my patch. Reproducably so, I might add. Steps taken: - update building environment, a Debian Sid pbuilder chroot - remove patch from most recent package revision in Debian - test build, "make test" fails, for a log please see below - add patch again - test build, "make test" succeeds, for a log please see below The files at <http://people.debian.org/~florian/libconfig-general-perl/> are the logs, the diff.gz's as applied to your upstream sources as well as the corresponding upstream tarball and the .dsc's for easy reproducability in a Debian environment. Anyway, as I have passed maintainership of this package to Francesco in March 2006 I've added a CC to him so he can comment / follow up on this. Cheers, Flo
Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

RT-Send-CC: Francesco Cecconi <francesco.cecconi [...] gmail.com>
Well, the test fails because of this: 23:48:18 E: Useless use of concatenation (.) or string in void context at blib/lib/Config/General/Interpolated.pm line 94. In line Interpolated.pm:94 was a bug, which I fixed (ok, one hour ago), see rt#24232. The problem with test::harness is that it is really weird if a test fails and counts with invalid numbers, for whatever reason. I'll change the test toolkit these days anyway so this behaviour will get away.
Subject: Re: [rt.cpan.org #17150] make test: Failed 1/1 test scripts, 0.00% okay. -1/24 subtests failed, 104.17% okay.
Date: Fri, 23 Feb 2007 01:30:26 +0100
To: bug-Config-General [...] rt.cpan.org
From: Francesco Cecconi <francesco.cecconi [...] gmail.com>
Hi, On Friday 23 February 2007, via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=17150 > > > Well, the test fails because of this: > > 23:48:18 E: Useless use of concatenation (.) or string in void context > at blib/lib/Config/General/Interpolated.pm line 94. > > In line Interpolated.pm:94 was a bug, which I fixed (ok, one hour ago), > see rt#24232.
Show quoted text
> > The problem with test::harness is that it is really weird if a test > fails and counts with invalid numbers, for whatever reason. > > I'll change the test toolkit these days anyway so this behaviour will > get away.
Well, I'll fix this bug on next release. Many Thanks, Francesco -- .''`. ** Debian GNU/Linux ** | Francesco Cecconi ' |BrAnD| ' : :' : The Universal O.S. | francesco.cecconi@gmail.com `. `'` | GPG Key ID: 11F6E468 `- *Debian Pkg Maintainer* | JID brand80@jabber.linux.it
Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.

Uploaded Config::General 2.32, it'll take some time to appear. Case finally closed.