| Subject: | Broken dependency and test dependencies |
This report refers to version 0.01.
This module requires Data::Random, but it isn't listed in the
dependencies in the Build.PL file.
There are two test scripts, 02-create.t and 03-verify.t, that require
Test::WWW::Mechanize but don't check for its existence first.
The attached patch addresses these issues.
Thanks for your work on this module!
-E
| Subject: | cap-captcha.patch |
diff -ur CGI-Application-Plugin-CAPTCHA-0.01.orig/Build.PL CGI-Application-Plugin-CAPTCHA-0.01/Build.PL
--- CGI-Application-Plugin-CAPTCHA-0.01.orig/Build.PL 2006-01-19 01:23:54.604532624 -0500
+++ CGI-Application-Plugin-CAPTCHA-0.01/Build.PL 2006-01-19 01:27:10.505751112 -0500
@@ -12,6 +12,7 @@
'CGI::Application' => '>= 4.00',
'Module::Build' => 0,
'GD::SecurityImage' => 0,
+ 'Data::Random' => 0,
},
create_makefile_pl => 'traditional',
create_readme => 1,
diff -ur CGI-Application-Plugin-CAPTCHA-0.01.orig/t/02-create.t CGI-Application-Plugin-CAPTCHA-0.01/t/02-create.t
--- CGI-Application-Plugin-CAPTCHA-0.01.orig/t/02-create.t 2006-01-19 01:23:54.604532624 -0500
+++ CGI-Application-Plugin-CAPTCHA-0.01/t/02-create.t 2006-01-19 01:30:05.272182576 -0500
@@ -2,8 +2,14 @@
use strict;
use warnings;
-use Test::More tests => 4;
-use Test::WWW::Mechanize;
+use Test::More;
+
+BEGIN {
+ eval "use Test::WWW::Mechanize";
+ plan skip_all => "Test::WWW::Mechanize required for tests" if $@;
+}
+
+plan tests => 4;
# Bring in testing hierarchy
use lib './t';
diff -ur CGI-Application-Plugin-CAPTCHA-0.01.orig/t/03-verify.t CGI-Application-Plugin-CAPTCHA-0.01/t/03-verify.t
--- CGI-Application-Plugin-CAPTCHA-0.01.orig/t/03-verify.t 2006-01-19 01:23:54.604532624 -0500
+++ CGI-Application-Plugin-CAPTCHA-0.01/t/03-verify.t 2006-01-19 01:30:20.489869136 -0500
@@ -2,8 +2,14 @@
use strict;
use warnings;
-use Test::More tests => 7;
-use Test::WWW::Mechanize;
+use Test::More;
+
+BEGIN {
+ eval "use Test::WWW::Mechanize";
+ plan skip_all => "Test::WWW::Mechanize required for tests" if $@;
+}
+
+plan tests => 7;
# Bring in testing hierarchy
use lib './t';