Bug #17085 for SVN-Web: support for Apache2

Mon Jan 16 02:06:12 2006 DONGXU [...] cpan.org - Ticket created

Subject:

support for Apache2

Current days I am trying SVN::Web with Apache2. Everything is going fine except one issue. The browser couldn't get a valid response code from the module since in SVN::Web.pm the return code is hard-coded as: -------------------- sub handler { ... ... return Apache::OK; } -------------------- While with Apache2 should be Apache2::Const::OK. Is it possible to add Apache version check here, then eval specific OK here? Maybe check $VERSION from APR or ModPerl. I am not very familiar with Apache and ModPerl. Best Regards, Dongxu

Tue Jan 24 11:49:34 2006 NIKC [...] cpan.org - Correspondence added

Hi, On Mon Jan 16 02:06:12 2006, DONGXU wrote: Show quoted text

> Current days I am trying SVN::Web with Apache2. Everything is going fine > except one issue. The browser couldn't get a valid response code from > the module since in SVN::Web.pm the return code is hard-coded as: > -------------------- > sub handler { > ... ... > return Apache::OK; > } > -------------------- > While with Apache2 should be Apache2::Const::OK. > Is it possible to add Apache version check here, then eval specific OK > here? Maybe check $VERSION from APR or ModPerl. I am not very familiar > with Apache and ModPerl.

Thanks for the bug report. Unfortunately, I don't know anything about Apache2 and mod_perl2. As you have a working Apache2 installation, could you try your suggestion, and if it works for you, please could you send me a patch so I can include it in the next release of SVN::Web. Thank you. N

Tue Jan 24 11:49:35 2006 The RT System itself - Status changed from 'new' to 'open'

Sun Jan 29 18:15:36 2006 NIKC [...] cpan.org - Correspondence added

Show quoted text

> > Is it possible to add Apache version check here, then eval specific > > OK here?

Could you try the attached patch and let me know if it works for you. Thanks. N

Download diff
application/octet-stream 1.3k

Message body not shown because it is not plain text.

Mon Jan 30 12:40:50 2006 dongxu.ma [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #17085] support for Apache2
Date:	Tue, 31 Jan 2006 01:39:46 +0800
To:	bug-SVN-Web [...] rt.cpan.org
From:	Dongxu Ma <dongxu.ma [...] gmail.com>

Thanks for the patch. Currently I am on vacation. Try it once I come back. On 1/30/06, via RT <bug-SVN-Web@rt.cpan.org> wrote: Show quoted text

>

> > > Is it possible to add Apache version check here, then eval specific > > > OK here?

> > Could you try the attached patch and let me know if it works for you. > Thanks. > > N > > >

-- Cheers, Dongxu

Tue Jan 31 03:20:40 2006 Guest - Correspondence added

From:

dietrich.streifert [...] visionet.de

On So. 29. Jan. 2006, 18:15:36, NIKC wrote: Show quoted text

> > > Is it possible to add Apache version check here, then eval specific > > > OK here?

> > Could you try the attached patch and let me know if it works for you. > Thanks. > > N

Tried the patch against SVN::Web 0.43 and it works for me on Apache/2.0.55 (Unix) DAV/2 SVN/1.2.3 mod_perl/2.0.2 Perl/v5.8.7 Thank you!

Tue Jan 31 07:45:57 2006 NIKC [...] cpan.org - Correspondence added

Fixed with the change in http://jc.ngo.org.uk/svnweb/jc/revision?rev=775. This will be in 0.44. Thanks for the report.

Tue Jan 31 07:45:58 2006 NIKC [...] cpan.org - Status changed from 'open' to 'resolved'