Bug #1703 for Tie-DB_Lock: _random_string()'s length is random too

Tue Oct 22 00:01:30 2002 gbrock [...] cpan.org - Ticket created

Subject:

_random_string()'s length is random too

Using perl 5.6.0 on Solaris 2.5.1. In Tie::DB_Lock, at line 74, you call &_random_string; The _random_string() subroutine then chooses the length of the sting based on shift || 9, but due to the lack of ()'s in the call, @_ is unpredictable. On my system, the length is 420 characters and so the copy fails! Easy fix is to change line 74 from: my $tempfile = "$TEMPDIR/" . &_random_string; to my $tempfile = "$TEMPDIR/" . &_random_string(); Regards, Gavin

Tue Oct 22 17:29:41 2002 kwilliams [...] cpan.org - Status changed from 'new' to 'resolved'

Tue Oct 22 17:29:41 2002 kwilliams [...] cpan.org - Correspondence added

[GBROCK - Tue Oct 22 00:01:30 2002]: Show quoted text

> Using perl 5.6.0 on Solaris 2.5.1. > > In Tie::DB_Lock, at line 74, you call &_random_string; The > _random_string() subroutine then chooses the length of the sting > based on shift || 9, but due to the lack of ()'s in the call, @_ is > unpredictable. On my system, the length is 420 characters and so > the copy fails! > > Easy fix is to change line 74 from: > my $tempfile = "$TEMPDIR/" . &_random_string; > to > my $tempfile = "$TEMPDIR/" . &_random_string(); > > Regards, > > Gavin

Thanks for the report. I've fixed this and added a test in a new version, 0.07. -Ken