Skip Menu |

This queue is for tickets about the GDGraph CPAN distribution.

Maintainer(s)' notes

There are plenty of good ideas of what people can do published here on the queue. Turning a patch from the tracker into a pull request is not one of them. In order to get maintainers' attention way more quickier, PR should have at least a sample included. We know it's hard to test images generating software, but it doesn't mean we can not test numbers produced by intermediate algorithms used to generate these images, so either a test or a sample.

Report information
The Basics
Id: 16880
Status: resolved
Priority: 0/
Queue: GDGraph

People
Owner: Nobody in particular
Requestors: janne [...] janne.nu
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.4305
Fixed in: 1.4306



When checking for sensible values in axestype::set_max_min:1618 iteration is performed over the first two datasets (1 .. 2), not the two different axes! You have to iterate over all datasets and check the bounds via use_axis: GDGraph-1.4305/Graph/axestype.pm 1620c1620 < for my $i (1 .. 2) --- Show quoted text
> for my $i (1 .. $self->{_data}->num_sets)
1624c1624 < if $self->{y_min}[$i] > $min; --- Show quoted text
> if $self->{y_min}[$self->{use_axis}[$i-1]] > $min;
1626c1626 < if $self->{y_max}[$i] < $max; --- Show quoted text
> if $self->{y_max}[$self->{use_axis}[$i-1]] < $max;
Subject: Erroneous checking for sensible values in axestype
When checking for sensible values in axestype::set_max_min:1618 iteration is performed over the first two datasets (1 .. 2), not the two different axes! You have to iterate over all datasets and check the bounds via use_axis: GDGraph-1.4305/Graph/axestype.pm 1620c1620 < for my $i (1 .. 2) --- Show quoted text
> for my $i (1 .. $self->{_data}->num_sets)
1624c1624 < if $self->{y_min}[$i] > $min; --- Show quoted text
> if $self->{y_min}[$self->{use_axis}[$i-1]] > $min;
1626c1626 < if $self->{y_max}[$i] < $max; --- Show quoted text
> if $self->{y_max}[$self->{use_axis}[$i-1]] < $max;
Yes, that should have been patched when the support for more multiple axes on more than two datasets went in--thanks! On Tue Jan 03 06:56:22 2006, guest wrote: Show quoted text
> When checking for sensible values in axestype::set_max_min:1618 > iteration is performed over the first two datasets (1 .. 2), not the > two different axes! > > You have to iterate over all datasets and check the bounds via > use_axis: > > GDGraph-1.4305/Graph/axestype.pm > 1620c1620 > < for my $i (1 .. 2) > ---
> > for my $i (1 .. $self->{_data}->num_sets)
> 1624c1624 > < if $self->{y_min}[$i] > $min; > ---
> > if $self->{y_min}[$self->{use_axis}[$i-1]] > $min;
> 1626c1626 > < if $self->{y_max}[$i] < $max; > ---
> > if $self->{y_max}[$self->{use_axis}[$i-1]] < $max;