Bug #16868 for TomKit: Dangerous use of $

Mon Jan 02 12:47:05 2006 yanick+cpan [...] babyl.dyndns.org - Ticket created

Subject:

Dangerous use of $_ in anonymous foreach loop

In TomKitEngine.pm's runEngine, an anonymous foreach is used: foreach ( @processorChain ) { $_->setUp(); $dom = $_->process($dom); ... $processor = $_; } This will break if process() does anything to $_. A suggestion of a patch is included.

Download patch
application/octet-stream 1.1k

Message body not shown because it is not plain text.

Thu Feb 09 12:05:50 2012 RURBAN [...] cpan.org - Correspondence added

I've asked the maintainer and he is not doing perl anymore. His modules are up for grab. So if anyone wants it, ask him and he will give you co-maint on pause, so that you can apply those patches. -- Reini Urban

Thu Feb 09 12:05:53 2012 The RT System itself - Status changed from 'new' to 'open'

Thu Feb 09 12:47:40 2012 yanick+cpan [...] babyl.dyndns.org - Correspondence added

On Thu Feb 09 12:05:50 2012, RURBAN wrote: Show quoted text

> I've asked the maintainer and he is not doing perl anymore. > His modules are up for grab. > So if anyone wants it, ask him and he will give you co-maint on pause, so > that you can apply those patches.

I'm game. :-)

Thu Feb 09 12:52:25 2012 yanick.champoux [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #16868] Dangerous use of $_ in anonymous foreach loop
Date:	Thu, 09 Feb 2012 12:52:13 -0500
To:	bug-TomKit [...] rt.cpan.org, tomson [...] cpan.org
From:	Yanick Champoux <yanick.champoux [...] gmail.com>

Tom, As mentioned in the ticket, if you are willing, I can take co-maintainership of TomKit. I don't see much further development on it, as AxKit has died down in those last few years, but I can make sure patches are applied and the garden is kept nice and tidy. :-) Joy, `/anick

Sat Feb 11 20:02:30 2012 yanick+cpan [...] babyl.dyndns.org - Correspondence added

aaand the new version is on CPAN. And it seems that, indeed, as it's all trial versions, I was able to take over without any fuss. :-)

Bug #16868 for TomKit: Dangerous use of $_ in anonymous foreach loop