Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-File CPAN distribution.

Report information
The Basics
Id: 16782
Status: resolved
Worked: 20 min
Priority: 0/
Queue: Test-File
People
Owner: bdfoy [...] cpan.org
Requestors: grousse [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.12
Fixed in: (no value)

History Show all quoted text
  Thu Dec 29 04:41:03 2005 grousse [...] cpan.org - Ticket created
Subject: owner test is broken
Attached patch fix the test.
--- t/owner.t 2005-12-26 03:02:43.000000000 +0100 +++ t/owner.t.new 2005-12-29 10:39:08.000000000 +0100 @@ -57,10 +57,8 @@ my $name = 'Intentional owner_is failure'; test_out( "not ok 1 - $name"); test_diag( - "File [$filename] belongs to $owner_name ($owner_uid), not $other_name " . - "($other_uid)\n" . - "# Failed test '$name'\n". - "# in t/owner.t at line " . line_num(+6) . "." + "File [$filename] belongs to $owner_name ($owner_uid), not $other_name ($other_uid)", + " Failed test (t/owner.t at line " . line_num(+4) . ")" ); owner_is( $filename, $other_name, $name ); test_test( $name ); @@ -69,9 +67,8 @@ test_out( "not ok 1 - $name"); test_diag( - "File [$filename] belongs to $owner_name ($owner_uid)\n" . - "# Failed test '$name'\n" . - "# in t/owner.t at line " . line_num(+5) . "." - ); + "File [$filename] belongs to $owner_name ($owner_uid)", + " Failed test (t/owner.t at line " . line_num(+4) . ")" +); owner_isnt( $filename, $owner_name, "Intentional owner_isnt failure" ); -test_test( "Intentional owner_isnt failure"); \ No newline at end of file +test_test( "Intentional owner_isnt failure");
  Thu Dec 29 11:45:15 2005 bdfoy [...] cpan.org - Status changed from 'new' to 'open'
  Thu Dec 29 11:54:00 2005 bdfoy [...] cpan.org - Correspondence added 5 min
Which version of Test::Harness and Test::Builder::Tester do you have? I think your versions may give different diagnostic output (and wouldn't that be wonderful?). With your patch, the owner.t test breaks for me. Since the owner.t has passed all of the CPAN Testers so far, I expect it will break for them if I change it.
  Thu Dec 29 11:54:00 2005 bdfoy [...] cpan.org - Given to BDFOY
  Thu Dec 29 12:25:02 2005 grousse [...] cpan.org - Correspondence added
[BDFOY - Thu Dec 29 11:54:00 2005]: Show quoted text
> Which version of Test::Harness and Test::Builder::Tester do you have?
Test::Harness is 2.48 Test::Builder::Tester is 1.0.1 This is using perl 5.8.7 on mandrake cooker.
  Sat Dec 31 07:43:28 2005 Guest - Correspondence added
[GROUSSE - Thu Dec 29 12:25:02 2005]: Show quoted text
> [BDFOY - Thu Dec 29 11:54:00 2005]: >
> > Which version of Test::Harness and Test::Builder::Tester do you
> have? > Test::Harness is 2.48 > Test::Builder::Tester is 1.0.1 > > This is using perl 5.8.7 on mandrake cooker.
The patch supplied by GROUSSE works for me on the following systems: Red Hat Linux 9, Test::Harness 2.26, Test::Builder::Tester 1.01 Red Hat Enterprise Linux 3, Test::Harness 2.26, Test::Builder::Tester 0.09 Red Hat Enterprise Linux 3, Test::Harness 2.26, Test::Builder::Tester 1.01 Red Hat Enterprise Linux 4, Test::Harness 2.42, Test::Builder::Tester 1.01 Fedora Core 1, Test::Harness 2.40, Test::Builder::Tester 1.01 Fedora Core 2, Test::Harness 2.40, Test::Builder::Tester 1.01 Fedora Core 3, Test::Harness 2.42, Test::Builder::Tester 1.01 Fedora Core 4, Test::Harness 2.42, Test::Builder::Tester 1.01 Fedora Core rawhide, Test::Harness 2.48, Test::Builder::Tester 1.01 I have no systems on which the patch does not work.
  Sat Dec 31 15:59:50 2005 bdfoy [...] cpan.org - Correspondence added 15 min
Curious. The output comes from Test::Builder::ok(), and the format of that output changed between Test-Simple-0.60 and Test-Simple-0.62. I have the latest version of Test::Builder, which is 0.32, and you probably have the earlier versions. You can see this in the Changes file for Test::Simple. The way I have it now is the current way Test::Builder does it, so I guess I'll have to make that a prerequisite now. I'm not sure why the output had to change.
  Sat Dec 31 15:59:50 2005 bdfoy [...] cpan.org - Status changed from 'open' to 'resolved'