Bug #16661 for Maypole: model search/delete methods model and subclassing the cdbi model

Wed Dec 21 07:57:49 2005 TEEJAY [...] cpan.org - Ticket created

Subject:

model search/delete methods model and subclassing the cdbi model

Problems with clashing delete/search methods can occur when subclassing the cdbi model, as class::dbi and any equivilent will use these methodnames. Matt S Trout has provided a quick fix that will enable subclassing to work nicer.. my ($sub) = (caller(1))[3]; $sub =~ /^(.+)::([^:]+)$/; # So subclasses can still send search down ... return shift->SUPER::search(@_) if ($1 ne "Maypole::Model::Base" && $2 ne "search"); It is reccomended that you use the new do_search/do_delete model methods to avoid method resolution clashes.

Wed Dec 21 07:59:33 2005 TEEJAY [...] cpan.org - Correspondence added

[TEEJAY - Wed Dec 21 07:57:49 2005]: Show quoted text

> Problems with clashing delete/search methods can occur when > subclassing > the cdbi model, as class::dbi and any equivilent will use these > methodnames. > > Matt S Trout has provided a quick fix that will enable subclassing to > work nicer.. > > my ($sub) = (caller(1))[3]; > $sub =~ /^(.+)::([^:]+)$/; > # So subclasses can still send search down ... > return shift->SUPER::search(@_) if ($1 ne "Maypole::Model::Base" && > $2 ne "search"); > > It is reccomended that you use the new do_search/do_delete model > methods > to avoid method resolution clashes.

I am updating the Model classes to provide do_search and do_delete, and for the CDBI model to call either the SUPER::search or do_search depending on the improved hack that MST has provided. Once I can commit these changes to SVN, I'll provide the revision number here.

Wed Dec 21 07:59:34 2005 TEEJAY [...] cpan.org - Status changed from 'new' to 'open'

Wed Dec 21 07:59:34 2005 TEEJAY [...] cpan.org - Given to TEEJAY

Tue Dec 27 13:24:04 2005 TEEJAY [...] cpan.org - Correspondence added

[TEEJAY - Wed Dec 21 07:59:33 2005]: Show quoted text

> [TEEJAY - Wed Dec 21 07:57:49 2005]: >

> > Problems with clashing delete/search methods can occur when > > subclassing > > the cdbi model, as class::dbi and any equivilent will use these > > methodnames. > > > > Matt S Trout has provided a quick fix that will enable subclassing to > > work nicer.. > > > > my ($sub) = (caller(1))[3]; > > $sub =~ /^(.+)::([^:]+)$/; > > # So subclasses can still send search down ... > > return shift->SUPER::search(@_) if ($1 ne "Maypole::Model::Base" && > > $2 ne "search"); > > > > It is reccomended that you use the new do_search/do_delete model > > methods > > to avoid method resolution clashes.

> > > I am updating the Model classes to provide do_search and do_delete, and > for the CDBI model to call either the SUPER::search or do_search > depending on the improved hack that MST has provided. > > Once I can commit these changes to SVN, I'll provide the revision number > here.

Fixed in SVN 442

Wed Aug 02 11:19:28 2006 TEEJAY [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Aug 02 11:19:28 2006 TEEJAY [...] cpan.org - Fixed in 2.11 added