Bug #16392 for Net-DNS: TCP Sockets stay open even if not requested

Fri Dec 09 10:58:22 2005 Guest - Ticket created

Subject:

TCP Sockets stay open even if not requested

File Base.pm, Line 626 $self->{'sockets'}[AF_UNSPEC]{$sock_key} = $sock; must be: $self->{'sockets'}[AF_UNSPEC]{$sock_key} = $sock if $self->persistent_tcp;

Fri Dec 09 12:58:54 2005 OLAF [...] cpan.org - Correspondence added

[guest - Fri Dec 9 10:58:22 2005]: Show quoted text

> File Base.pm, Line 626 > > $self->{'sockets'}[AF_UNSPEC]{$sock_key} = $sock; > > must be: > > $self->{'sockets'}[AF_UNSPEC]{$sock_key} = $sock if $self->persistent_tcp; > >

Thanks... How did you notice this bug? I ask because I would like to assess how painful this bug actually is and if I should quickly release a new version with a fix. --Olaf

Fri Dec 09 13:15:07 2005 Guest - Correspondence added

[OLAF - Fri Dec 9 12:58:54 2005]: Show quoted text

> [guest - Fri Dec 9 10:58:22 2005]: >

> > File Base.pm, Line 626 > > > > $self->{'sockets'}[AF_UNSPEC]{$sock_key} = $sock; > > > > must be: > > > > $self->{'sockets'}[AF_UNSPEC]{$sock_key} = $sock if $self-

> >persistent_tcp;

> > > >

> > Thanks... > > How did you notice this bug? I ask because I would like to assess how > painful this bug > actually is and if I should quickly release a new version with a fix.

By reviewing before using :-/ I expect especially on servers that do like 80.000 DNS Verifications a day and like (guessed) 5%-10% of them truncated packets, that this will lead to SOMAXCONN issues. I've had already an issue with that part of code with version 0.53 (see http://thread.gmane.org/gmane.mail.postfix.policyd-weight/112) and wanted to recheck it now, the issue I had seems to be fixed, but I encountered that TCP Sockets are stored, regardless of persistent_* settings - which will affect truncated UDP packets, too. I'm not sure myself, how to priorize it. As there is no setting to avoid it. And currently, until it is fully evaluated, I rather keep persistent off as default. -- rob

Fri Dec 09 17:35:45 2005 olaf [...] dacht.net - Correspondence added

From:	"Olaf M. Kolkman" <olaf [...] dacht.net>
Subject:	Re: [cpan #16392] TCP Sockets stay open even if not requested
Date:	Fri, 9 Dec 2005 23:34:18 +0100
To:	bug-Net-DNS [...] rt.cpan.org
RT-Send-Cc:

Hello Rob, Thanks for the link and assesment. I applied the patch (also for AXFR method that suffered the same). It is now on the trunk (http://www.net-dns.sec/svn/net-dns/trunk ). I'll ponder about a quick release over the weekend. All in all, I am not very happy about the structure of Base.pm. It is in need of some cleanup and restructuring, also automatic fallback to IPv4 could be improved. --Olaf ------------------------------------------------------ Ik dacht net... heel even maar.

Download PGP.sig
application/pgp-signature 227b

Message body not shown because it is not plain text.

Mon Dec 19 05:45:14 2005 OLAF [...] cpan.org - Status changed from 'new' to 'resolved'