Bug #16343 for CGI: url function return extra '?' or empty query string

Wed Dec 07 10:20:38 2005 Guest - Ticket created

Subject:

url function return extra '?' or empty query string

When using $q->url in a CGI script that weas invoked with an empty query string: http://mysite/cgi-bin/prog? The result URL will incorrectly include the '?'. According to the perldoc, the '?' (and the query string) will be included only if the parameter query is set. The problem is caused by line 2634 (CGI.pm 3.14), which will eliminate the '?' only if there are some characters after the '?'. 2633 my $uri = $rewrite && $request_uri ? $request_uri : $script_name; 2634 $uri =~ s/\?.+$// if defined $query_str; 2635 $uri =~ s/$path$// if defined $path; # remove path from URI The fix is to use 's/\?.*$//' to filter out the query string. VERSION=3.14 $Id: CGI.pm,v 1.194 2005/12/06 22:12:56 lstein Exp $ INPUT=/~yair/x.cgi? URL=http://ybgweb/~yair/x.cgi? VERSION=3.14 $Id: CGI.pm,v 1.194 2005/12/06 22:12:56 lstein Exp $ INPUT=/~yair/x.cgi? URL=http://ybgweb/~yair/x.cgi? Test Program: #! /usr/local/bin/perl use CGI ; my $q = new CGI() ; print $q->header('text/plain') ; print "VERSION=$CGI::VERSION $CGI::revision\n" ; print "INPUT=$ENV{REQUEST_URI}\n"; print "URL=", $q->url, "\n" ;

Thu Dec 08 07:04:14 2005 Guest - Correspondence added

From:

jbw [...] jbw.pl

[guest - Wed Dec 7 10:20:38 2005]: This is tragic! It screwed up hundrets of my CGIs. IMO the function script_name() makes troubles. We see in CGI.pm: sub script_name { my ($self,@p) = self_or_default(@_); if (@p) { $self->{'.script_name'} = shift; } elsif (!exists $self->{'.script_name'}) { my ($script_name,$path_info) = $self->_name_and_path_from_env(); $self->{'.script_name'} = $script_name; } return $self->{'.script_name'}; } But some time ago we saw something less sophisticated, but more working: sub script_name { return $ENV{'SCRIPT_NAME'} if defined($ENV{'SCRIPT_NAME'}); # These are for debugging return "/$0" unless $0=~/^\//; return $0; } When I replaced function body with this older version, all my scripts again works good.

Tue Dec 27 14:06:26 2005 LDS [...] cpan.org - Taken

Tue Dec 27 14:07:33 2005 LDS [...] cpan.org - Status changed from 'new' to 'resolved'

Wed Jun 07 18:14:56 2006 Guest - Correspondence added

On Wed Dec 07 10:20:38 2005, guest wrote: Show quoted text

> When using $q->url in a CGI script that weas invoked with an empty > query string: > http://mysite/cgi-bin/prog? > > The result URL will incorrectly include the '?'. > > According to the perldoc, the '?' (and the query string) will be > included only if the parameter query is set. The problem is caused > by line 2634 (CGI.pm 3.14), which will eliminate the '?' only if > there are some characters after the '?'. > > 2633 my $uri = $rewrite && $request_uri ?

$request_uri Show quoted text

> : $script_name; > 2634 $uri =~ s/\?.+$// if defined > $query_str; > 2635 $uri =~ s/$path$// if defined $path; > # remove path from URI > > The fix is to use 's/\?.*$//' to filter out the query string. > > VERSION=3.14 $Id: CGI.pm,v 1.194 2005/12/06 22:12:56 lstein Exp $ > INPUT=/~yair/x.cgi? > URL=http://ybgweb/~yair/x.cgi? > > > VERSION=3.14 $Id: CGI.pm,v 1.194 2005/12/06 22:12:56 lstein Exp $ > INPUT=/~yair/x.cgi? > URL=http://ybgweb/~yair/x.cgi? > > > > Test Program: > > #! /usr/local/bin/perl > use CGI ; > my $q = new CGI() ; > print $q->header('text/plain') ; > print "VERSION=$CGI::VERSION $CGI::revision\n" ; > print "INPUT=$ENV{REQUEST_URI}\n"; > print "URL=", $q->url, "\n" ;

Wed Jun 07 18:14:57 2006 The RT System itself - Status changed from 'resolved' to 'open'

Mon Jul 20 21:44:50 2009 MARKSTOS [...] cpan.org - Correspondence added

This was fixed in 3.15: 1. Remove extraneous "?" from self_url() when URI contains a ? but no query string.

Mon Jul 20 21:44:51 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'

Fri May 23 14:28:34 2014 The RT System itself - Queue changed from CGI.pm to CGI

Bug #16343 for CGI: url function return extra '?' or empty query string

Preferred bug tracker