Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SVN-Notify CPAN distribution.

Report information
The Basics
Id: 16050
Status: resolved
Worked: 2 hours (120 min)
Priority: 0/
Queue: SVN-Notify
People
Owner: dwheeler [...] cpan.org
Requestors: zehrer [...] zepan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 2.50
Fixed in: 2.63
Attachments
smime.p7s

History Show all quoted text
  Wed Nov 23 04:31:59 2005 Guest - Ticket created
Subject: Special Characters
Special Characters don't work, even when one uses the correct charset with -c. See the discussion at http://www.justatheory.com/computers/programming/perl/modules/svnnotify_2.50.html
  Thu Feb 23 16:09:27 2006 dwheeler [...] cpan.org - Correspondence added
Subject: Re: [cpan #16050] Special Characters
Date: Thu, 23 Feb 2006 13:08:31 -0800
To: bug-SVN-Notify [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On Nov 23, 2005, at 01:32, Guest via RT wrote: Show quoted text
> Special Characters don't work, even when one uses the correct > charset with -c.
I believe that I've fixed this issue. Look for the fix in 2.53 soonish! Best, David
  Thu Feb 23 16:09:28 2006 The RT System itself - Status changed from 'new' to 'open'
  Mon Apr 03 19:02:34 2006 dwheeler [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Apr 03 19:02:38 2006 dwheeler [...] cpan.org - Fixed in 2.53 added
  Fri Jun 23 09:44:01 2006 Zehrer [...] optimal-systems.de - Correspondence added
Subject: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Fri, 23 Jun 2006 15:43:05 +0200
To: <bug-SVN-Notify [...] rt.cpan.org>
From: "Michael Zehrer" <Zehrer [...] optimal-systems.de>
Sorry for the late answer, but I tested this now with 2.60 an the problem still exists. "für" gives "f?\195?\188r" Best, Michael Show quoted text
-----Ursprüngliche Nachricht----- Von: David Wheeler via RT [mailto:bug-SVN-Notify@rt.cpan.org] Gesendet: Dienstag, 4. April 2006 01:03 An: Michael Zehrer Betreff: [rt.cpan.org #16050] Resolved: Special Characters <URL: http://rt.cpan.org/Ticket/Display.html?id=16050 > According to our records, your request has been resolved. If you have any further questions or concerns, please respond to this message.
Download smime.p7s
application/x-pkcs7-signature 3.2k

Message body not shown because it is not plain text.

  Fri Jun 23 09:44:03 2006 The RT System itself - Status changed from 'resolved' to 'open'
  Fri Jun 23 11:11:28 2006 david [...] kineticode.com - Correspondence added
Subject: Re: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Fri, 23 Jun 2006 08:10:40 -0700
To: bug-SVN-Notify [...] rt.cpan.org
From: David Wheeler <david [...] kineticode.com>
On Jun 23, 2006, at 06:44, Michael Zehrer via RT wrote: Show quoted text
> "für" gives "f?\195?\188r"
Did you use the --charset or --io-layer options? Best, David
  Sat Jun 24 04:35:43 2006 zehrer [...] zepan.org - Correspondence added
Subject: Re: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Sat, 24 Jun 2006 10:35:15 +0200
To: bug-SVN-Notify [...] rt.cpan.org
From: Michael Zehrer <zehrer [...] zepan.org>
I use both: -c iso-8859-1 --io-layer raw Am Freitag, den 23.06.2006, 11:11 -0400 schrieb David Wheeler via RT: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=16050 > > > On Jun 23, 2006, at 06:44, Michael Zehrer via RT wrote: >
> > "für" gives "f?\195?\188r"
> > Did you use the --charset or --io-layer options? > > Best, > > David
Download smime.p7s
application/x-pkcs7-signature 1.6k

Message body not shown because it is not plain text.

  Sat Jun 24 10:51:23 2006 dwheeler [...] cpan.org - Correspondence added
Subject: Re: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Sat, 24 Jun 2006 07:48:25 -0700
To: bug-SVN-Notify [...] rt.cpan.org
From: David Wheeler <dwheeler [...] cpan.org>
On Jun 24, 2006, at 01:35, zehrer@zepan.org via RT wrote: Show quoted text
> I use both: -c iso-8859-1 --io-layer raw
With raw, it will output whatever it reads in. What if you leave out --io-layer? David
  Sat Jun 24 14:13:27 2006 zehrer [...] zepan.org - Correspondence added
Subject: Re: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Sat, 24 Jun 2006 20:12:57 +0200
To: bug-SVN-Notify [...] rt.cpan.org
From: Michael Zehrer <zehrer [...] zepan.org>
No change, still the same error. Michael Am Samstag, den 24.06.2006, 10:51 -0400 schrieb David Wheeler via RT: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=16050 > > > On Jun 24, 2006, at 01:35, zehrer@zepan.org via RT wrote: >
> > I use both: -c iso-8859-1 --io-layer raw
> > With raw, it will output whatever it reads in. What if you leave out > --io-layer? > > David >
Download smime.p7s
application/x-pkcs7-signature 1.6k

Message body not shown because it is not plain text.

  Sat Jun 24 20:43:28 2006 david [...] kineticode.com - Correspondence added
Subject: Re: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Sat, 24 Jun 2006 17:43:05 -0700
To: bug-SVN-Notify [...] rt.cpan.org
From: David Wheeler <david [...] kineticode.com>
On Jun 24, 2006, at 11:13, zehrer@zepan.org via RT wrote: Show quoted text
> No change, still the same error.
I have no idea, then. :-( David
  Tue Jul 11 22:46:03 2006 david [...] kineticode.com - Correspondence added
Subject: Re: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Tue, 11 Jul 2006 19:45:32 -0700
To: bug-SVN-Notify [...] rt.cpan.org
From: David Wheeler <david [...] kineticode.com>
Try this patch, please: --- lib/SVN/Notify.pm (revision 2982) +++ lib/SVN/Notify.pm (working copy) @@ -5,7 +5,9 @@ use strict; use constant WIN32 => $^O eq 'MSWin32'; use constant PERL58 => $] > 5.007; +use POSIX qw(locale_h); $SVN::Notify::VERSION = '2.63'; +setlocale(LC_CTYPE, 'C'); =begin comment
  Mon Jul 31 19:33:42 2006 dwheeler [...] cpan.org - Correspondence added
Subject: Re: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Mon, 31 Jul 2006 16:33:19 -0700
To: bug-SVN-Notify [...] rt.cpan.org
From: David Wheeler <dwheeler [...] cpan.org>
Never mind. The solution is actually to set the $LANG environment variable to your locale. Something like this: LANG=fr_FR.ISO8859-1 /usr/local/bin/svnnotify \ --repos-path "$1" \ --revision "$2" \ ... It seems that this is required for sendmail to do the right thing. I'll add a note in the docs about this issue. Best, David
  Tue Aug 01 10:59:44 2006 zehrer [...] zepan.org - Correspondence added
Subject: Re: AW: [rt.cpan.org #16050] Resolved: Special Characters
Date: Tue, 01 Aug 2006 16:59:18 +0200
To: bug-SVN-Notify [...] rt.cpan.org
From: Michael Zehrer <zehrer [...] zepan.org>
Hi David, this works also for me. Thank you very much for don't giving up in the encoding hell. Michael David Wheeler via RT schrieb: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=16050 > > > Never mind. The solution is actually to set the $LANG environment > variable to your locale. Something like this: > > LANG=fr_FR.ISO8859-1 /usr/local/bin/svnnotify \ > --repos-path "$1" \ > --revision "$2" \ > ... > > It seems that this is required for sendmail to do the right thing. > I'll add a note in the docs about this issue. > > Best, > > David > >
  Thu Aug 03 13:51:19 2006 dwheeler [...] cpan.org - Correspondence added 120 min
I think that I've finally got this issue nailed. 2.63 sets the LANG environment variable before it executes sendmail. So be sure to specify --language and --charset to properly set LANG to your locale, and then, hopefully, it will just work. If not, then I give up. Just set the LANG environment variable in your hook script before you execute svnnotify, and leave out the --language option. I've had reports that this approach does the trick.
  Thu Aug 03 13:51:20 2006 dwheeler [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Aug 03 13:51:23 2006 dwheeler [...] cpan.org - Given to DWHEELER
  Thu Aug 03 13:53:28 2006 dwheeler [...] cpan.org - Fixed in 2.63 added
  Thu Aug 03 13:53:28 2006 dwheeler [...] cpan.org - Fixed in 2.53 deleted