Skip Menu |

This queue is for tickets about the HTML-Strip CPAN distribution.

Report information
The Basics
Id: 15907
Status: resolved
Priority: 0/
Queue: HTML-Strip
People
Owner: Nobody in particular
Requestors: rurban [...] x-ray.at
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.04
Fixed in: 1.07

History Show all quoted text
  Thu Nov 17 14:27:35 2005 RURBAN [...] cpan.org - Ticket created
Subject: MSVC stricmp
Attached patch fixes compilation on MSVC, which has no strcasecmp()
2005-11-17 20:23:40 rurban@cpan.org * MSVC doesnt define strcasecmp, use stricmp instead --- HTML-Strip-1.04/strip_html.c.orig 2005-01-24 17:42:04.000000000 +0100 +++ HTML-Strip-1.04/strip_html.c 2005-11-17 20:22:29.228125000 +0100 @@ -4,6 +4,9 @@ #include <string.h> #include "strip_html.h" +#ifdef _MSC_VER +#define strcasecmp(a,b) stricmp(a,b) +#endif void strip_html( Stripper * stripper, const char * raw, char * output ) {
  Tue Jul 25 07:44:13 2006 KILINRAX [...] cpan.org - Correspondence added
On Thu Nov 17 14:27:35 2005, RURBAN wrote: Show quoted text
> Attached patch fixes compilation on MSVC, which has no strcasecmp()
Firstly, apologies for the slow reply. The email address my CPAN address was forwarding to died, and I lost a bunch of bug emails. I'll work this into the next release of the module.
  Tue Jul 25 07:44:14 2006 The RT System itself - Status changed from 'new' to 'open'
  Sun Oct 26 04:09:55 2008 cosimo [...] cpan.org - Correspondence added
On Mar. 25 Lug. 2006 07:44:13, KILINRAX wrote: Show quoted text
> On Thu Nov 17 14:27:35 2005, RURBAN wrote:
> > Attached patch fixes compilation on MSVC, which has no strcasecmp()
> > Firstly, apologies for the slow reply. The email address my CPAN
address Show quoted text
> was forwarding to died, and I lost a bunch of bug emails. > > I'll work this into the next release of the module.
Any news? Are you still interested in maintaining this module? If not, ping me please. I also have this problem and I'd like to have the patch applied. Let me know thanks!
  Wed Sep 24 08:30:30 2014 KILINRAX [...] cpan.org - Correspondence added
Applied in 1.07: https://metacpan.org/release/KILINRAX/HTML-Strip-1.07
  Wed Sep 24 08:30:33 2014 KILINRAX [...] cpan.org - Status changed from 'open' to 'patched'
  Wed Sep 24 08:35:11 2014 KILINRAX [...] cpan.org - Correspondence added
RT-Send-CC: cosimo [...] cpan.org
Cosimo - I've started updating this module again. I added Dmuey as a comaint but he never seems to have released anything. Let me know if you want to have comaint also.
  Wed Sep 24 08:35:12 2014 KILINRAX [...] cpan.org - Status changed from 'patched' to 'resolved'
  Wed Sep 24 09:14:59 2014 dmuey [...] cpan.org - Correspondence added
On Wed Sep 24 08:35:11 2014, KILINRAX wrote: Show quoted text
> Cosimo - I've started updating this module again. I added Dmuey as a > comaint but he never seems to have released anything. Let me know if > you want to have comaint also.
correct, I never did get around to it, priorities :) If you want to take me off you can otherwise I’ll help when I can!
  Wed Sep 24 15:06:59 2014 RURBAN [...] cpan.org - Correspondence added
On Wed Sep 24 08:35:11 2014, KILINRAX wrote: Show quoted text
> Cosimo - I've started updating this module again. I added Dmuey as a > comaint but he never seems to have released anything. Let me know if > you want to have comaint also.
I'm confused. Aren't you mixing people up here? I fixed this issue 2005, and my fellow coworker dmuey had nothing to do with it. -- Reini Urban
  Fri Sep 26 11:38:39 2014 KILINRAX [...] cpan.org - Correspondence added
On Wed Sep 24 15:06:59 2014, RURBAN wrote: Show quoted text
> I'm confused. Aren't you mixing people up here? > I fixed this issue 2005, and my fellow coworker dmuey had nothing to > do with it.
I don't believe so? You provided the patch, and I was swamped with other priorities so didn't apply it. Cosimo offered to comaintain the module to apply the patches. I added him as comaint. I'd just realised he hadn't updated the module in the years since, so applied the patches, fixed the bugs I could, and uploaded a new release. You're credited in the Changelog for the patch, btw. I've also set up a git repo: https://github.com/kilinrax/HTML-Strip
  Fri Sep 26 11:38:40 2014 KILINRAX [...] cpan.org - Fixed in 1.07 added
  Fri Sep 26 14:54:57 2014 rurban [...] x-ray.at - Correspondence added
Subject: Re: [rt.cpan.org #15907] MSVC stricmp
Date: Fri, 26 Sep 2014 13:54:45 -0500
To: bug-HTML-Strip [...] rt.cpan.org
From: Reini Urban <rurban [...] x-ray.at>
Ah good. I was confused about dmuey On Sep 26, 2014 10:38 AM, "Alex Bowley via RT" <bug-HTML-Strip@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=15907 > > > On Wed Sep 24 15:06:59 2014, RURBAN wrote:
> > I'm confused. Aren't you mixing people up here? > > I fixed this issue 2005, and my fellow coworker dmuey had nothing to > > do with it.
> > I don't believe so? You provided the patch, and I was swamped with other > priorities so didn't apply it. Cosimo offered to comaintain the module to > apply the patches. I added him as comaint. I'd just realised he hadn't > updated the module in the years since, so applied the patches, fixed the > bugs I could, and uploaded a new release. > > You're credited in the Changelog for the patch, btw. I've also set up a > git repo: https://github.com/kilinrax/HTML-Strip > >