Skip Menu |

This queue is for tickets about the Text-NSP CPAN distribution.

Report information
The Basics
Id: 15861
Status: resolved
Priority: 0/
Queue: Text-NSP

People
Owner: TPEDERSE [...] cpan.org
Requestors: grousse [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.73
Fixed in: (no value)



Subject: Installation procedure for documentation is unsafe
Makefile.PL shipped in Text::NSP reimplements manually installation procedure for documentation files, trying to install them directly under $(SITEPREFIX)/doc. This is incorrect in packaging installation scenarios, where files are installed under $(DESTDIR)/$(SITEPREFIX) on the build host, not directly on the target host. Morevoer, documentation installation location is not standardized at all (apart man and info pages) on Unix system, so the makefile should just generate the documentation and let user install it. Finally, MakeMaker already takes cares of generating and installing man pages, everything in Makefile.PL is just redundant to default behaviour.
From: tpederse
Thank you for reporting this problem. It has been resolved in version 0.99, where we allow Makefile.PL to install the documentation in system default locations. On Wed Nov 16 09:01:16 2005, GROUSSE wrote: Show quoted text
> Makefile.PL shipped in Text::NSP reimplements manually installation > procedure for documentation files, trying to install them
directly Show quoted text
> under $(SITEPREFIX)/doc. This is incorrect in packaging > installation scenarios, where files are installed under > $(DESTDIR)/$(SITEPREFIX) on the build host, not directly on the > target host. > > Morevoer, documentation installation location is not standardized at > all (apart man and info pages) on Unix system, so the makefile > should just generate the documentation and let user install it. > > Finally, MakeMaker already takes cares of generating and installing > man pages, everything in Makefile.PL is just redundant to default > behaviour.
Le Ven. Jun. 23 01:13:23 2006, guest a écrit : Show quoted text
> Thank you for reporting this problem. It has been resolved in version > 0.99, where we allow Makefile.PL to install the documentation in system > default locations.
Indeed. Two additional cosmetics remarks: - you're still duplicating a lot of standard installation procedures about PREFIX and other class MakeMaker options. And your warning after installation are a bit overzealous: unless you used PREFIX, INSTALLBIN is supposed to be in your PATH already, and INSTALLSITELIB in @INC (no need to set PERL5LIB). The added value of such explanations, related to the added complexity to display them in your Makefile.PL, and duplication with INSTALL file, is discussable IMHO. - there is a lot of CVS directories still present in the archive, that ought to be removed at distribution time.
We have removed the CVS directories in 1.01. That was a slip, normally we do not include those in the distributions. The "warning" messages displayed after installation are due to a fairly large number of user questions about the installation proceess - we have quite a few users who are neither system administrators nor regular perl users (yet?) and there seemed to be a lot of confusion about how to do a local install. Those questions have abated somewhat since including those warnings, so I guess for now I'd like to keep them around. On Fri Jun 23 04:10:51 2006, guest wrote: Show quoted text
> Le Ven. Jun. 23 01:13:23 2006, guest a écrit :
> > Thank you for reporting this problem. It has been resolved in
version Show quoted text
> > 0.99, where we allow Makefile.PL to install the documentation in
system Show quoted text
> > default locations.
> Indeed. > > Two additional cosmetics remarks: > - you're still duplicating a lot of standard installation procedures > about PREFIX and other class MakeMaker options. And your warning
after Show quoted text
> installation are a bit overzealous: unless you used PREFIX,
INSTALLBIN Show quoted text
> is supposed to be in your PATH already, and INSTALLSITELIB in @INC
(no Show quoted text
> need to set PERL5LIB). The added value of such explanations, related
to Show quoted text
> the added complexity to display them in your Makefile.PL, and > duplication with INSTALL file, is discussable IMHO. > > - there is a lot of CVS directories still present in the archive,
that Show quoted text
> ought to be removed at distribution time. >