Skip Menu |

This queue is for tickets about the XML-NamespaceSupport CPAN distribution.

Report information
The Basics
Id: 155
Status: resolved
Priority: 0/
Queue: XML-NamespaceSupport

People
Owner: Nobody in particular
Requestors: rho [...] bigpond.net.au
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.02
Fixed in: (no value)



Subject: warnings during make test
I see warnings during make test of my packages using XML::Namespacesupport Use of uninitialized value in string eq at /usr/local/lib/perl5/site_perl/5.6.1/XML/NamespaceSupport.pm line I have tweak/silenced it via 0a1 Show quoted text
>
79c80 < my $prefix = shift || ''; --- Show quoted text
> my $prefix = shift;
154c155 < my $prefix = shift || ''; --- Show quoted text
> my $prefix = shift;
[DRRHO - Sat Jan 19 13:23:58 2002]: Show quoted text
> I see warnings during make test of my packages using > XML::Namespacesupport > > Use of uninitialized value in string eq at > /usr/local/lib/perl5/site_perl/5.6.1/XML/NamespaceSupport.pm line > > I have tweak/silenced it via > > 0a1
> >
> 79c80 > < my $prefix = shift || ''; > ---
> > my $prefix = shift;
> 154c155 > < my $prefix = shift || ''; > ---
> > my $prefix = shift;
Thanks for the patch but I don't think that would be the correct behaviour. Undefined warnings are there to let one know that something is wrong. In this case, both those methods expect $prefix to be '' if it is the empty prefix, not undef. That's intentional as an undef $prefix would normally mean that there's a problem somewhere. I'm leaving this bug open in case you have an argument to convince me of the contrary, but I'm not for silencing warnings that can provide valuable information. -- --darobin