Bug #15389 for Sort-External: Fails to compile on FreeBSD

Sat Oct 29 10:27:48 2005 aar [...] cpan.org - Ticket created

Subject:

Fails to compile on FreeBSD

Greetings, Sort::External fails to compile for perl v5.8.2 built for i386-freebsd. bash-2.05b# make cc -c -DAPPLLIB_EXP="/usr/local/lib/perl5/5.8.2/BSDPAN" -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -I/usr/local/include -O -pipe -march=pentiumpro -DVERSION=\"0.12\" -DXS_VERSION=\"0.12\" -DPIC -fPIC "-I/usr/local/lib/perl5/5.8.2/mach/CORE" External.c External.xs: In function `XS_Sort__External__print_to_sortfile': External.xs:58: syntax error before `char' External.xs:61: `encoded_len' undeclared (first use in this function) External.xs:61: (Each undeclared identifier is reported only once External.xs:61: for each function it appears in.) External.xs: In function `XS_Sort__External__Buffer__refill_buffer': External.xs:91: syntax error before `char' External.xs:104: `amount_read' undeclared (first use in this function) External.xs:108: `item_length' undeclared (first use in this function) External.xs:110: `check' undeclared (first use in this function) External.xs:110: `read_buf' undeclared (first use in this function) External.xs:142: `num_items' undeclared (first use in this function) *** Error code 1 Stop in /usr/local/src/Search-Kinosearch-0.021/Sort-External-0.12.

Sat Oct 29 14:54:59 2005 CREAMYG [...] cpan.org - Taken

Sat Oct 29 16:02:05 2005 marvin [...] rectangular.com - Correspondence added

From:	Marvin Humphrey <marvin [...] rectangular.com>
Subject:	Re: [cpan #15389] Fails to compile on FreeBSD
Date:	Sat, 29 Oct 2005 13:01:34 -0700
To:	bug-Sort-External [...] rt.cpan.org
RT-Send-Cc:

The make failures are a little hard to figure... I've been advised that the first may be due to the declaration of the variable inside a for loop. The second, I'm guessing has to do with the comment just before it. This patch for External.xs addresses both of those "issues". Can you give it a crack on your system, Alessandro? It works for me with Perl 5.8.5 on FreeBSD 5.3 -- but then, so did the original.

Message body is not shown because sender requested not to inline it.

Marvin Humphrey Rectangular Research http://www.rectangular.com/

Sun Oct 30 04:13:48 2005 aar [...] cpan.org - Correspondence added

Hello Marvin, still getting errors: bash-2.05b# make cc -c -DAPPLLIB_EXP="/usr/local/lib/perl5/5.8.2/BSDPAN" -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -I/usr/local/include -O -pipe -march=pentiumpro -DVERSION=\"0.12\" -DXS_VERSION=\"0.12\" -DPIC -fPIC "-I/usr/local/lib/perl5/5.8.2/mach/CORE" External.c External.xs: In function `XS_Sort__External__Buffer__refill_buffer': External.xs:91: syntax error before `char' External.xs:104: `amount_read' undeclared (first use in this function) External.xs:104: (Each undeclared identifier is reported only once External.xs:104: for each function it appears in.) External.xs:108: `item_length' undeclared (first use in this function) External.xs:110: `check' undeclared (first use in this function) External.xs:110: `read_buf' undeclared (first use in this function) External.xs:142: `num_items' undeclared (first use in this function) *** Error code 1 Stop in /usr/local/src/Search-Kinosearch-0.021/Sort-External-0.12. bash-2.05b# cc -v Using builtin specs. gcc version 2.95.4 20020320 [FreeBSD] bash-2.05b# uname -a FreeBSD xx.hostingcenter.it 4.9-RELEASE-p4 FreeBSD 4.9-RELEASE-p4 #0: Fri Apr 9 16:29:13 CEST 2004 root@xx.hostingcenter.it:/usr/obj/usr/src/sys/GENERIC i386

Sun Oct 30 19:58:20 2005 marvin [...] rectangular.com - Correspondence added

From:	Marvin Humphrey <marvin [...] rectangular.com>
Subject:	Re: [cpan #15389] Fails to compile on FreeBSD
Date:	Sun, 30 Oct 2005 16:57:51 -0800
To:	bug-Sort-External [...] rt.cpan.org
RT-Send-Cc:

Show quoted text

> Hello Marvin, still getting errors:

Thanks for both the bug report and the followup. Members of the perl- xs list have fleshed out their initial diagnoses; it seems likely that the problem arises from the fact that declaration statements which include executable code are legal in C99, but not before. I'm including a version of External.xs which moves all declarations to the PREINIT: section. Please give it a try. Best, Marvin Humphrey Rectangular Research http://www.rectangular.com/

Message body is not shown because sender requested not to inline it.

Mon Oct 31 04:26:50 2005 aar [...] cpan.org - Correspondence added

From:

Alessandro Ranellucci <aar [...] cpan.org>

[marvin@rectangular.com - Sun Oct 30 19:58:20 2005]: Show quoted text

> [...] I'm > including a version of External.xs which moves all declarations to > the PREINIT: section. Please give it a try.

That fixed the issue. Thank you, Marvin, for the quick feedback. Cheers, - alessandro ranellucci.

Wed Nov 02 11:46:34 2005 CREAMYG [...] cpan.org - Fixed in 0.14 added

Wed Nov 02 11:49:24 2005 CREAMYG [...] cpan.org - Status changed from 'new' to 'resolved'