Bug #15299 for Net-DNS: Test error in t/00-load for Net::DNS::Nameserver

Tue Oct 25 18:20:35 2005 Guest - Ticket created

Subject:

Test error in t/00-load for Net::DNS::Nameserver

Net-DNS 0.53_02 This is perl, v5.6.1 built for sun4-solaris SunOS vtn1 5.8 Generic_117350-25 sun4u sparc Running 'make test' produces the following error: PERL_DL_NONLAZY=1 /usr/local/bin/perl -Iblib/arch -Iblib/lib -I/usr/local/lib/perl5/5.6.1/sun4-solaris -I/usr/local/lib/perl5/5.6.1 -e 'use Test::Harness qw(&runtests $verbose); $verbose=0; runtests @ARGV;' t/*.t t/00-load..................ok 2/75 t/00-load..................NOK 3# Failed test (t/00-load.t at line 10) # Tried to use 'Net::DNS::Nameserver'. # Error: Constant name 'HASH(0x3bbb58)' has invalid characters at blib/lib/Net/DNS/Nameserver.pm line 22 # BEGIN failed--compilation aborted at t/00-load.t line 10. # Compilation failed in require at (eval 10) line 2. # BEGIN failed--compilation aborted at (eval 10) line 2. t/00-load..................ok 75/75# Looks like you failed 1 test of 75. t/00-load..................dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 3 Failed 1/75 tests, 98.67% okay

Tue Oct 25 18:36:58 2005 olaf [...] dacht.net - Correspondence added

From:	"Olaf M. Kolkman" <olaf [...] dacht.net>
Subject:	Re: [cpan #15299] Test error in t/00-load for Net::DNS::Nameserver
Date:	Wed, 26 Oct 2005 00:36:23 +0200
To:	bug-Net-DNS [...] rt.cpan.org
RT-Send-Cc:

I fail to reproduce the bug (I would have noticed it before) so this might be something other versions of perl/OS are less sensitive for. Anyway, around line 22 of lib/Net/DNS/Namedropper.pm there is a space lacking before the "=>". Could you try if inserting a space there fixes the error? STATE_GOT_LENGTH => 2, Its a not tested fix but I have a gut feeling that might be the cause of error. --Olaf (off-line for a couple of days).

Download PGP.sig
application/pgp-signature 227b

Message body not shown because it is not plain text.

Tue Oct 25 19:06:23 2005 Guest - Correspondence added

From:

iwhite [...] victoria.tc.ca

[olaf@dacht.net - Tue Oct 25 18:36:58 2005]: Show quoted text

> > > I fail to reproduce the bug (I would have noticed it before) so this > might be something other versions of perl/OS are less sensitive for.

Apparently constant changed in 5.8 to allow for multiple constants to be set at once. For 5.6 compatability each one has to be defined individually.

--- Nameserver.pm.orig 2005-10-25 16:03:00.758328000 -0700 +++ Nameserver.pm 2005-10-25 16:03:55.908095000 -0700 @@ -15,11 +15,9 @@ @DEFAULT_ADDR $DEFAULT_PORT ); -use constant { - STATE_ACCEPTED => 1, - STATE_GOT_LENGTH=> 2, - STATE_SENDING => 3 - }; +use constant STATE_ACCEPTED => 1; +use constant STATE_GOT_LENGTH => 2; +use constant STATE_SENDING => 3; $VERSION = (qw$LastChangedRevision: 502 $)[1];

Wed Oct 26 01:53:10 2005 olaf [...] dacht.net - Correspondence added

From:	"Olaf M. Kolkman" <olaf [...] dacht.net>
Subject:	Re: [cpan #15299] Test error in t/00-load for Net::DNS::Nameserver
Date:	Wed, 26 Oct 2005 07:52:29 +0200
To:	bug-Net-DNS [...] rt.cpan.org
RT-Send-Cc:

On Oct 26, 2005, at 01:06 , Guest via RT wrote: Show quoted text

> > Apparently constant changed in 5.8 to allow for multiple constants > to be set at once. For 5.6 > compatability each one has to be defined individually. >

Thanks, I was not aware of that and that particular code fragment came to me through a patch. What's your full name so I can acknowledge you in the Changes File (Apologies for not doing the research myself, it was midnight in my timezone and did not have the time to dive deeper than just looking at the code...) The fix lives on the subversion trunk: http://www.net-dns.org/svn/net- dns/trunk --Olaf

Download PGP.sig
application/pgp-signature 227b

Message body not shown because it is not plain text.

Wed Oct 26 18:05:21 2005 Guest - Correspondence added

From:

iwhite [...] victoria.tc.ca

Show quoted text

> Thanks, I was not aware of that and that particular code fragment > came to me through a patch. What's your full name so I can > acknowledge you in the Changes File > > (Apologies for not doing the research myself, it was midnight in my > timezone and did not have the time to dive deeper than just looking > at the code...)

Ian White. And not a problem, glad I could figure it out on my own and save you some effort. Thanks for all the work you put into this.

Tue Nov 08 20:52:24 2005 OLAF [...] cpan.org - Status changed from 'new' to 'resolved'