Bug #1523 for XML-SAX-Machines: XML::SAX::Machines does not pass tests on perl 5.9.0

Tue Sep 17 05:20:21 2002 Guest - Ticket created

Subject:

XML::SAX::Machines does not pass tests on perl 5.9.0

I've just tried a CPAN install of XML::SAX::Machines under my nightly bulid of perl 5.9.0 (it identifies itself as DEVEL17881 and has DEBUGGING turned on if that's of any use). Is this information of any use to you? -Dom

Download cpan.log
application/octet-stream 23.4k

Message body not shown because it is not plain text.

Tue Sep 17 05:45:17 2002 barries [...] slaysys.com - Correspondence added

Date:	Tue, 17 Sep 2002 06:17:47 -0400
From:	Barrie Slaymaker <barries [...] slaysys.com>
To:	Guest via RT <bug-XML-SAX-Machines [...] rt.cpan.org>
Cc:	"'AdminCc of cpan Ticket #1523'": ;
Subject:	Re: [cpan #1523] XML::SAX::Machines does not pass tests on perl 5.9.0

On Tue, Sep 17, 2002 at 05:20:21AM -0400, Guest via RT wrote: Show quoted text

> > I've just tried a CPAN install of XML::SAX::Machines under my nightly bulid of perl 5.9.0 (it identifies itself as DEVEL17881 and has DEBUGGING turned on if that's of any use). > > Is this information of any use to you?

Only if I can see the error messages. Make sure that your XML-SAX-Writer is up to date, 0.41 is terribly buggy and breaks XML::SAX::Machines' test suite. Thanks, Barrie

Thu Mar 13 14:43:38 2008 ntyni [...] iki.fi - Correspondence added

From:

ntyni [...] iki.fi

On Tue Sep 17 05:45:17 2002, barries@slaysys.com wrote: Show quoted text

> On Tue, Sep 17, 2002 at 05:20:21AM -0400, Guest via RT wrote:

> > > > I've just tried a CPAN install of XML::SAX::Machines under my

> nightly bulid of perl 5.9.0 (it identifies itself as DEVEL17881 and > has DEBUGGING turned on if that's of any use).

> > > > Is this information of any use to you?

> > Only if I can see the error messages. Make sure that your XML-SAX- > Writer is > up to date, 0.41 is terribly buggy and breaks XML::SAX::Machines' test > suite.

FWIW, this was about XML::SAX::Machines using pseudo hashes, which were removed with the 5.9 branch. As 5.10 is now stable, this has now become a more serious issue. The attached trivial patch doesn't seem to break anything, so I applied it for the Debian package. (This is also Debian bug #467316, http://bugs.debian.org/467316) Cheers, -- Niko Tyni (Debian Perl Group) ntyni@debian.org

diff --git a/lib/XML/SAX/Machine.pm b/lib/XML/SAX/Machine.pm index e50ea75..1917676 100644 --- a/lib/XML/SAX/Machine.pm +++ b/lib/XML/SAX/Machine.pm @@ -1468,13 +1468,8 @@ sub new { my $proto = shift; my $class = ref $proto || $proto; - my $self = do { - no strict 'refs'; - bless [ \%{ "${class}::FIELDS" } ]; - }; - - ## Pseudo hashes are badly borken in older Perls. Should use something - ## else, really. + my $self = bless {}, $class; + my %options = @_ ; $self->{$_} = $options{$_} for keys %options;

Thu Mar 13 14:43:42 2008 The RT System itself - Status changed from 'new' to 'open'

Thu Jun 11 13:38:42 2009 cpan [...] prather.org - Correspondence added

Applied in fa00aa2ce8f26e02f8a23d3c4f4eaa1ad8c502c3 (see http://github.com/perigrin/xml-sax-machines/commit/fa00aa2ce8f26e02f8a23d3c4f4eaa1ad8c502c3 ) I'll make a release shortly.

Thu Jun 11 13:39:01 2009 cpan [...] prather.org - Status changed from 'open' to 'resolved'