| Date: | Tue, 10 Sep 2002 17:27:07 -0400 |
| From: | Chris Laas <golem [...] MIT.EDU> |
| To: | Lincoln Stein <lstein [...] cshl.org> |
| Cc: | bug-crypt-cbc [...] rt.cpan.org |
| Subject: | Re: Crypt::CBC bug |
Hi Lincoln,
My apologies, but I don't have the time to maintain your software as
well as mine. My message was a bug report with specific helpful
information about where the bug was --- it was not intended to be a
patch. jesse@fsck.com suggested I cc: bug-crypt-cbc@rt.cpan.org so
that the bug report would be generally visible on the RT queue ---
perhaps someone with more free time on their hands will be willing to
provide you with a tested patch.
Good luck,
--Chris
On Tue, Sep 10, 2002 at 03:23:58PM -0400, Lincoln Stein wrote:
Show quoted text
> Chris,
>
> Sorry, but please send me a patch file that implements this change AFTER you
> have run the regression tests to confirm that it works properly.
>
> Thanks,
>
> Lincoln
>
> On Tuesday 10 September 2002 08:23 am, Chris Laas wrote:
> > I believe that it would be adequate to replace that line with
> > my $rbs = length($padding->(" "x$i,$bs,'e'));
> > In other words, replace the 0 with 'e'.
> >
> > Cheers,
> > --Chris
> >
> > On Tue, Sep 10, 2002 at 08:21:22AM -0400, Lincoln Stein wrote:
> > > Hi,
> > >
> > > I didn't write the space padding. This was a contribution from someone
> > > else. If you understand the conventions, could you please provide a patch
> > > that I can apply?
> > >
> > > Thanks,
> > >
> > > Lincoln
> > >
> > > On Tuesday 10 September 2002 07:13 am, you wrote:
> > > > Crypt/CBC.pm, version 2.07, line 52:
> > > > my $rbs = length($padding->(" "x$i,$bs,0));
> > > >
> > > > This doesn't follow the 'e'/'d' direction convention, using 0 instead
> > > > --- my programs mysteriously croaked when I tested for 'e' instead of
> > > > 'd'. The default padding types use 'd', so this bug doesn't manifest
> > > > with them.
> > > >
> > > > Cheers,
> > > > --Chris
> > >
> > > --
> > > Lincoln Stein
> > > lstein@cshl.org