| Subject: | Proposal to modify the sbspace tests of t91udts.t |
Good morning Jonathan,
This is a proposal, not a complaint. :-)
I'd like to propose a modify in the default behaviour of t/t91udts.t test script.
The problem is that now DBD::Informix builds and tests fine only if I define the DBD_INFORMIX_NO_SBSPACE var, as you *have documented* in your README. I set up no sbspaces.
I found out this after reading the "bug" report ticket by Ron Campbell.
It seems that he also didn't read the documentation properly. :-)
So I thought that probably the default behaviour of that test should be the following:
- If I don't define DBD_INFORMIX_SBSPACE, skip the LOBs test
- If I define that, activate the tests
- If I define DBD_INFORMIX_SBSPACE and DBD_INFORMIX_NO_SBSPACE,
skip the tests.
So everyone that doesn't even read the readme is happy :-)
Attached is a patch that modifies the t91udts.t script and
the README to update the documentation accordingly.
DBD::Informix is a high quality software. Thanks Jonathan!
--- README 2005-07-29 19:19:43.000000000 +0200
+++ README_cosimo 2005-10-06 09:11:18.511931754 +0200
@@ -169,10 +169,11 @@
select mycol::lvarchar from mytab;
Note that the tests that create tables with BLOB or CLOB columns will
- place them in the smart blob space designated by DBD_INFORMIX_SBSPACE,
- and will use the default value 'sbspace' if you do not specify an
- alternative. If you do not have any smart blob spaces, the tests will
- fail unless you set DBD_INFORMIX_NO_SBSPACE.
+ place them in the smart blob space designated by DBD_INFORMIX_SBSPACE.
+ If that variable is empty, or does not exist, the LOB-related tests
+ will be skipped. This is also true if you set DBD_INFORMIX_NO_SBSPACE.
+ If you do not have any smart blob spaces but specify one, the tests
+ will fail. Don't submit bug reports about this!
Most versions of ESQL/C that support shared libraries have shared
linking as the default, which is correct. Other versions reportedly
--- t/t91udts.t 2005-07-29 19:20:09.000000000 +0200
+++ t/t91udts_cosimo.t 2005-10-06 09:06:03.898677834 +0200
@@ -23,9 +23,10 @@
&stmt_note("1..16\n");
-my ($noslobs) = $ENV{DBD_INFORMIX_NO_SBSPACE};
-
my ($sbspace) = $ENV{DBD_INFORMIX_SBSPACE};
+
+# If there isn't a defined sbspace, skip slobs tests
+my ($noslobs) = (! defined $sbspace || $sbspace eq '') ? 1 : $ENV{DBD_INFORMIX_NO_SBSPACE};
$sbspace = "sbspace" unless $sbspace;
sub do_stmt