Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 14915
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: thaljef [...] cpan.org
Requestors: chris+rt [...] chrisdolan.net
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.09
Fixed in: 0.10

History Show all quoted text
  Tue Oct 04 11:07:55 2005 cpan [...] clotho.com - Ticket created
Subject: v0.09 policies returning objects that aren't Violation instances
In v0.09 (sorry, wasn't available to RT when I filed this), the following policy modules return values from their violations() methods that aren't Perl::Critic::Violation instances. This results in blank lines in the perlcritic output. ControlStructures::ProhibitUntilBlocks ControlStructures::ProhibitUnlessBlocks ControlStructures::ProhibitPostfixControls ControlStructures::ProhibitCStyleForLoops -- Chris
  Tue Oct 04 14:22:17 2005 Guest - Correspondence added
From: thaljef [...] cpan.org
[CLOTHO - Tue Oct 4 11:07:55 2005]: Show quoted text
> In v0.09 (sorry, wasn't available to RT when I filed this), the > following policy modules return values from their violations() > methods that aren't Perl::Critic::Violation instances. This > results in blank lines in the perlcritic output. > > ControlStructures::ProhibitUntilBlocks > ControlStructures::ProhibitUnlessBlocks > ControlStructures::ProhibitPostfixControls > ControlStructures::ProhibitCStyleForLoops > > -- Chris
Ah, shit. I was up way too late last night. Funny thing is, it still passes the test case. Thanks for catching this. I'll probably put up a new release later today. -Jeff
  Thu Oct 06 10:10:18 2005 thaljef [...] cpan.org - Broken in 0.09 added
  Thu Oct 06 10:10:19 2005 thaljef [...] cpan.org - Fixed in 0.10 added
  Thu Oct 06 10:10:19 2005 thaljef [...] cpan.org - CustomField 0.08_02 deleted
  Thu Oct 06 10:10:49 2005 thaljef [...] cpan.org - Correspondence added
I was a bonehead. Fixed in version 0.10.
  Thu Oct 06 10:10:50 2005 thaljef [...] cpan.org - Status changed from 'new' to 'resolved'
  Wed Oct 12 03:35:28 2005 thaljef [...] cpan.org - Owner forcibly changed from Nobody to THALJEF