Skip Menu |

This queue is for tickets about the Maypole-FormBuilder CPAN distribution.

Report information
The Basics
Id: 14866
Status: new
Priority: 0/
Queue: Maypole-FormBuilder
People
Owner: Nobody in particular
Requestors: rmcclain [...] megapath.net
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.44
Fixed in: (no value)

History Show all quoted text
  Fri Sep 30 19:08:43 2005 Guest - Ticket created
Subject: ADDTO doesn't set fields from edit_columns
Shouldn't this: $args->{fields} ||= [$proto->edit_columns]; be in the ADDTO coderef? Also, there are a couple places where you use = instead of ||=. I know I can override setup_form_mode, but it's a (minor) pain. It seems like all of the actions by default should use the options passed to as_form if supplied. Would it hurt anything?
  Fri Sep 30 20:09:20 2005 dave.riverside [...] gmail.com - Correspondence added
Date: Sat, 1 Oct 2005 01:08:56 +0100
From: David Baird <dave.riverside [...] gmail.com>
To: bug-Maypole-FormBuilder [...] rt.cpan.org
Subject: Re: [cpan #14866] ADDTO doesn't set fields from edit_columns
RT-Send-Cc:
On 10/1/05, Guest via RT <bug-Maypole-FormBuilder@rt.cpan.org> wrote: Show quoted text
> > This message about Maypole-FormBuilder was sent to you by guest <> via rt.cpan.org > > Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=14866 > > > Shouldn't this: > $args->{fields} ||= [$proto->edit_columns]; > be in the ADDTO coderef? >
Yes! Except it should be addto_columns, and it should be = - see below. Show quoted text
> Also, there are a couple places where you use = instead of ||=. I know I can override setup_form_mode, but it's a (minor) pain. It seems like all of the actions by default should use the options passed to as_form if supplied. Would it hurt anything? > >
I agree there are some ='s that should be ||='s, I'll have a look, but I don't agree that the field list is one of them. The only other place you can specify the field list is in the template, but if you do that, the form in the template will have a different set of fields from the form in the exported action method. d.