Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 1473
Status: resolved
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: Nobody in particular
Requestors: crazyinsomniac [...] yahoo.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in:
  • 6.00
  • 6.01
  • 6.02
  • 6.03
Fixed in: (no value)



Subject: IF ABSTRACT has " in it, nmake ppd fails on win32
Hello Schwern. I am Podmaster (cpanid). IF ABSTRACT has " in it, nmake ppd fails on win32. I haven't seen an author with a " in his name, but you can't be too safe. AFAIK, this is broken in 5.45 and 6.x. I don't know if this warrants changes in MM_Unix.t or not, but either way i'm not a Test::More guy ;) --- lib/ExtUtils/MM_Unix.pm 2002-06-15 21:14:44.000000000 -0700 +++ lib/ExtUtils/MM_Unix.pm.mine 2002-08-26 03:36:31.000000000 -0700 @@ -3171,11 +3171,13 @@ $abstract =~ s/\n/\\n/sg; $abstract =~ s/</&lt;/g; $abstract =~ s/>/&gt;/g; + $abstract =~ s/"/\\"/g; my $author = $self->{AUTHOR} || ''; $author =~ s/</&lt;/g; $author =~ s/>/&gt;/g; $author =~ s/@/\\@/g; + $author =~ s/"/\\"/g; my $make_ppd = sprintf <<'PPD_OUT', $pack_ver, $abstract, $author; # Creates a PPD (Perl Package Description) for a binary distribution.
[guest - Mon Aug 26 06:45:15 2002]: Show quoted text
> IF ABSTRACT has " in it, nmake ppd fails on win32. > I haven't seen an author with a " in his name, but you can't be too > safe.
How did you happen to notice this?
From: crazyinsomniac [...] yahoo.com
Show quoted text
> How did you happen to notice this?
Well, my newest module HTML::LinkExtractor has the following pod =head1 NAME HTML::LinkExtractor - Extract I<L<links|/"WHAT'S A LINK-type tag">> from an HTML document That is how I stumbled accross this.
Ok, fixed. Though there's lots more places where this sort of thing can happen. Snapshot with the fix is available on makemaker.org. It will be in 6.06.