Bug #14695 for Maypole-Plugin-QuickTable: sort links not displaying on searches

Wed Sep 21 19:38:32 2005 Guest - Ticket created

Subject:

sort links not displaying on searches

Hmm. After upgrading from .303 to .41, sort links are not being generated when doing a 'do_search'. It generates the headers, but no links. This happens even if you do not submit a form but just hit the do_search url directly. I don't really see offhand how this happens, since in that case it just passes off to list() anyway.. are you seeing the same thing?

Wed Sep 21 20:27:48 2005 Guest - Correspondence added

[guest - Wed Sep 21 19:38:32 2005]: Show quoted text

> Hmm. After upgrading from .303 to .41, sort links are not being > generated when doing a 'do_search'. It generates the headers, but > no links. This happens even if you do not submit a form but just > hit the do_search url directly. I don't really see offhand how > this happens, since in that case it just passes off to list() > anyway.. are you seeing the same thing?

Fix: near the end of tabulate(), change my @headers = $self->action eq 'list' ? $self->_make_linked_header(map {$names{$_}} @fields; to my $action = $self->action; my @headers = (grep { /$action/ } qw(list search)) ? $self->_make_linked_headers( map { $names{ $_ } } @fields; It used to work. Something must have changed.

Wed Sep 21 20:32:36 2005 Guest - Correspondence added

[guest - Wed Sep 21 20:27:48 2005]: Show quoted text

> [guest - Wed Sep 21 19:38:32 2005]: >

> > Hmm. After upgrading from .303 to .41, sort links are not being > > generated when doing a 'do_search'. It generates the headers,

> but

> > no links. This happens even if you do not submit a form but just > > hit the do_search url directly. I don't really see offhand how > > this happens, since in that case it just passes off to list() > > anyway.. are you seeing the same thing?

> > > Fix: > near the end of tabulate(), change > my @headers = $self->action eq 'list' ? $self->_make_linked_header(map > {$names{$_}} @fields; > to > my $action = $self->action; > my @headers = (grep { /$action/ } qw(list search)) ? > $self->_make_linked_headers( map { $names{ $_ } } @fields; > > It used to work. Something must have changed.

er I mean.. my $action = $self->action; my @headers = (grep { /$action/ } qw(list do_search)) ? $self->_make_linked_headers( map { $names{ $_ } } @fields; Would be nice to get rid of do_{action} type actions. Far as I can tell, we don't need them.

Sun Sep 25 20:10:15 2005 dave.riverside [...] gmail.com - Correspondence added

Date:	Mon, 26 Sep 2005 01:09:52 +0100
From:	David Baird <dave.riverside [...] gmail.com>
To:	bug-Maypole-Plugin-QuickTable [...] rt.cpan.org
Subject:	Re: [cpan #14695] sort links not displaying on searches
RT-Send-Cc:

On 9/22/05, Guest via RT <bug-Maypole-Plugin-QuickTable@rt.cpan.org> wrote: Show quoted text

> > This message about Maypole-Plugin-QuickTable was sent to you by guest <> via rt.cpan.org > > Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=14695 > > > [guest - Wed Sep 21 20:27:48 2005]: >

> > [guest - Wed Sep 21 19:38:32 2005]: > >

> > > Hmm. After upgrading from .303 to .41, sort links are not being > > > generated when doing a 'do_search'. It generates the headers,

> > but

> > > no links. This happens even if you do not submit a form but just > > > hit the do_search url directly. I don't really see offhand how > > > this happens, since in that case it just passes off to list() > > > anyway.. are you seeing the same thing?

> > > > > > Fix: > > near the end of tabulate(), change > > my @headers = $self->action eq 'list' ? $self->_make_linked_header(map > > {$names{$_}} @fields; > > to > > my $action = $self->action; > > my @headers = (grep { /$action/ } qw(list search)) ? > > $self->_make_linked_headers( map { $names{ $_ } } @fields; > > > > It used to work. Something must have changed.

> > > er I mean.. > my $action = $self->action; > my @headers = (grep { /$action/ } qw(list do_search)) ? > $self->_make_linked_headers( map { $names{ $_ } } @fields; > > Would be nice to get rid of do_{action} type actions. Far as I can > tell, we don't need them. >

You're probably right, I've been meaning to tidy up the actions in that respect. d.