Bug #14652 for Class-DBI-FormBuilder: select lists not sorted

Mon Sep 19 18:44:42 2005 Guest - Ticket created

Subject:

select lists not sorted

select dropdowns are not sorted. This is a problem for me, as some of my select lists are large and it's impossible to find anything. In sub _field_options right before it returns, I added: @options = sort { $a->[1] <=> $b->[1] } @options;

Tue Sep 20 06:28:31 2005 cpan.zerofive [...] googlemail.com - Correspondence added

[guest - Mon Sep 19 18:44:42 2005]: Show quoted text

> select dropdowns are not sorted. This is a problem for me, as some of > my select lists are large and it's impossible to find anything. In > sub _field_options right before it returns, I added: > > @options = sort { $a->[1] <=> $b->[1] } @options; >

This assumes all the labels are numbers. If they're not, you'll get lots of warnings. If you use cmp instead, there'll be no warnings, but if your labels are numbers, they'll come out in weird order ( 1, 11, 111, 12, 2 ...). It's definitely something that needs fixed though. I think there's some way of specifiying a default order in CDBI for retrieving records, but I don't know where to start looking. There also might be an option in CGI-FB. d.

Tue Sep 20 06:28:32 2005 cpan.zerofive [...] googlemail.com - Status changed from 'new' to 'open'

Thu Sep 22 01:35:09 2005 Guest - Correspondence added

From:

rmcclain [...] megapath.net

[DAVEBAIRD - Tue Sep 20 06:28:31 2005]: Show quoted text

> [guest - Mon Sep 19 18:44:42 2005]: >

> > select dropdowns are not sorted. This is a problem for me, as some

> of

> > my select lists are large and it's impossible to find anything.

> In

> > sub _field_options right before it returns, I added: > > > > @options = sort { $a->[1] <=> $b->[1] } @options; > >

> > This assumes all the labels are numbers. If they're not, you'll get > lots > of warnings. If you use cmp instead, there'll be no warnings, but if > your labels are numbers, they'll come out in weird order ( 1, 11, 111, > 12, 2 ...). > > It's definitely something that needs fixed though. I think there's > some > way of specifiying a default order in CDBI for retrieving records, but > I > don't know where to start looking. There also might be an option in > CGI-FB. > > d.

There's a sortopts option in CGI::FB, but it also requires you to specify whether to use text or numeric sorting, so it's not much help. I didn't see anything in Class::DBI about a default sort order, but I'm not sure it would help anyway. Since you'd be sorting by the stringified object, you couldn't use database sorting in a lot of cases (e.g., when using stringify_self). Anyhow, I've patched my own copy of FB to use cmp on the values. Works well enough for me. At least I can find things. Sure, numeric only lists are ugly looking, but oh well.

Sun Sep 25 20:13:23 2005 dave.riverside [...] gmail.com - Correspondence added

Date:	Mon, 26 Sep 2005 01:12:59 +0100
From:	David Baird <dave.riverside [...] gmail.com>
To:	bug-Class-DBI-FormBuilder [...] rt.cpan.org
Subject:	Re: [cpan #14652] select lists not sorted
RT-Send-Cc:

On 9/22/05, Guest via RT <bug-Class-DBI-FormBuilder@rt.cpan.org> wrote: Show quoted text

> > This message about Class-DBI-FormBuilder was sent to you by guest <> via rt.cpan.org > > Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=14652 > > > [DAVEBAIRD - Tue Sep 20 06:28:31 2005]: >

> > [guest - Mon Sep 19 18:44:42 2005]: > >

> > > select dropdowns are not sorted. This is a problem for me, as some

> > of

> > > my select lists are large and it's impossible to find anything.

> > In

> > > sub _field_options right before it returns, I added: > > > > > > @options = sort { $a->[1] <=> $b->[1] } @options; > > >

> > > > This assumes all the labels are numbers. If they're not, you'll get > > lots > > of warnings. If you use cmp instead, there'll be no warnings, but if > > your labels are numbers, they'll come out in weird order ( 1, 11, 111, > > 12, 2 ...). > > > > It's definitely something that needs fixed though. I think there's > > some > > way of specifiying a default order in CDBI for retrieving records, but > > I > > don't know where to start looking. There also might be an option in > > CGI-FB. > > > > d.

> > > There's a sortopts option in CGI::FB, but it also requires you to > specify whether to use text or numeric sorting, so it's not much help. > I didn't see anything in Class::DBI about a default sort order, but I'm > not sure it would help anyway. Since you'd be sorting by the > stringified object, you couldn't use database sorting in a lot of cases > (e.g., when using stringify_self). Anyhow, I've patched my own copy of > FB to use cmp on the values. Works well enough for me. At least I can > find things. Sure, numeric only lists are ugly looking, but oh well. > >

Gotta sleep, but tomorrow I'll upload the latest, which allows you to provide a hash of coderefs (keyed by field name) to sort these things. The thing I thought I remembered in CDBI turned out to be just for has_many rels. d.

Mon Nov 21 17:34:53 2005 cpan.zerofive [...] googlemail.com - Status changed from 'open' to 'resolved'