Skip Menu |

This queue is for tickets about the Mail-DomainKeys CPAN distribution.

Report information
The Basics
Id: 14621
Status: resolved
Priority: 0/
Queue: Mail-DomainKeys

People
Owner: anthonyu [...] cpan.org
Requestors: pi [...] irrational.net
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.21
Fixed in: (no value)



Subject: Trailing empty lines are not properly removed
Trailing empty lines are not properly removed, as required by sections 3.4.2.1 and 3.4.2.2 of the DomainKeys specification (http://www.ietf.org/internet-drafts/draft-delany-domainkeys-base-02.txt). As a result, many messages are reported to have an invalid signature. Here is a quick fix which seems to work for me. Change Message.pm lines 175 through 180 to the following: foreach (reverse @{$self->{'BODY'}}) { /[^\t\r\n\ ]/ and last; /^[\t\r\n\ ]*$/ and pop @{$self->{'BODY'}}; } and change lines 215 through 220 to the following: foreach (reverse @{$self->{'BODY'}}) { /[^\r\n]/ and last; /^[\r\n]*$/ and pop @{$self->{'BODY'}}; } Hope this helps!
I applied your patch to version 0.23. Thanks for finding and fixing this bug!